[Parallel_libs-commits] [PATCH] D24177: [SE] Don't pack raw device mem args

[Jason Henline via Parallel_libs-commits]

jhen added inline comments.

================
Comment at: streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp:104
@@ -146,3 +103,3 @@
   auto Array = se::make_kernel_argument_pack(TypedShared);
-  ExpectEqual(nullptr, TypedShared.getByteCount(), Type::SHARED_DEVICE_MEMORY,
-              Array, 0);
+  ExpectEqual(nullptr, TypedShared.getElementCount() * sizeof(int),
+              Type::SHARED_DEVICE_MEMORY, Array, 0);
----------------
jlebar wrote:
> As a separate patch, I wonder if these classes should have a getByteCount() so you don't have to do this error-prone calculation.
Good idea. I'll do that.


https://reviews.llvm.org/D24177