[Parallel_libs-commits] [PATCH] D25701: Initial check-in of Acxxel (StreamExecutor renamed)
Justin Lebar via Parallel_libs-commits
parallel_libs-commits at lists.llvm.org
Tue Oct 25 11:42:48 PDT 2016
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
\o/
================
Comment at: acxxel/cuda_acxxel.cpp:546
+ else
+ return MaybePlatform.getValue();
+}
----------------
Can we just return MaybePlatform now, or does that not work because the types don't match? If so, maybe we should actually have a constructor on Expected which does this type conversion. (unique_ptr has something similar.) But we could do that in a separate patch.
https://reviews.llvm.org/D25701
More information about the Parallel_libs-commits
mailing list