[Parallel_libs-commits] [PATCH] D24107: [StreamExecutor] getOrDie and dieIfError utils

[James Price via Parallel_libs-commits]

jprice added a comment.

The `getOrDie` function seems to be generating an additional 'unchecked error' message when dying. For example, this trivial program (which should obviously generate an error):

  #include <streamexecutor/streamexecutor.h>
  
  namespace se = ::streamexecutor;
  
  int main(int argc, char *argv[])
  {
    se::Platform *platform =
      se::getOrDie(se::PlatformManager::getPlatformByName("foobar"));
  
    return 0;
  }

generates this output:

  Error extracting an expected value: no available platform with name foobar.
  Program aborted due to an unhandled Error:
  Error value was Success. (Note: Success values must still be checked prior to being destroyed).

Is this expected?


Repository:
  rL LLVM

https://reviews.llvm.org/D24107