[Parallel_libs-commits] [PATCH] D24066: [StreamExecutor] Add Doxygen main page

[Jason Henline via Parallel_libs-commits]

jhen added inline comments.

================
Comment at: streamexecutor/examples/Example.cpp:44
@@ +43,3 @@
+  }
+}
+/// [Example saxpy host helper functions]
----------------
jlebar wrote:
> Not for this patch, but these seem like they might be good as helpers in some public header.  (I see below that you're saying that users would want to convert to their own custom error-handling framework, but "getOrDie" does seem to be a pretty common way of "handling" errors.)
Sure, I'll add them as global helpers in a later patch.

================
Comment at: streamexecutor/examples/Example.cpp:161
@@ +160,3 @@
+  check(Device->freeDeviceMemory(X));
+  check(Device->freeDeviceMemory(Y));
+  /// [Example saxpy host main]
----------------
jlebar wrote:
> It's really too bad that we have to do this manually.  Would it be possible to make GlobalDeviceMemoryBase into an owning pointer?  We have GlobalDeviceMemorySlice as our non-owning pointer...
I was thinking the same thing. I'll create a patch to make that change.


https://reviews.llvm.org/D24066