[Parallel_libs-commits] [PATCH] D24066: [StreamExecutor] Add Doxygen main page

[Justin Lebar via Parallel_libs-commits]

jlebar added inline comments.

================
Comment at: streamexecutor/examples/Example.cpp:44
@@ +43,3 @@
+  }
+}
+/// [Example saxpy host helper functions]
----------------
Not for this patch, but these seem like they might be good as helpers in some public header.  (I see below that you're saying that users would want to convert to their own custom error-handling framework, but "getOrDie" does seem to be a pretty common way of "handling" errors.)

================
Comment at: streamexecutor/examples/Example.cpp:161
@@ +160,3 @@
+  check(Device->freeDeviceMemory(X));
+  check(Device->freeDeviceMemory(Y));
+  /// [Example saxpy host main]
----------------
It's really too bad that we have to do this manually.  Would it be possible to make GlobalDeviceMemoryBase into an owning pointer?  We have GlobalDeviceMemorySlice as our non-owning pointer...


https://reviews.llvm.org/D24066