[Parallel_libs-commits] [PATCH] D24043: [StreamExecutor] Simplify Kernel classes

[Jason Henline via Parallel_libs-commits]

jhen marked an inline comment as done.
jhen added a comment.

In https://reviews.llvm.org/D24043#529737, @jlebar wrote:

> Thanks a lot for all these reviews, jprice.


I second those sentiments. You've been a great help, jprice.


================
Comment at: streamexecutor/include/streamexecutor/Device.h:33
@@ -31,6 +32,3 @@
 
-  /// Gets the kernel implementation for the underlying platform.
-  virtual Expected<std::unique_ptr<KernelInterface>>
-  getKernelImplementation(const MultiKernelLoaderSpec &Spec) {
-    // TODO(jhen): Implement this.
-    return nullptr;
+  /// Creates a kernel object for this device.
+  ///
----------------
jlebar wrote:
> Can we be explicit that if this doesn't return an error, it is guaranteed not to return a null value?
Good idea.


https://reviews.llvm.org/D24043