[Parallel_libs-commits] [PATCH] D24043: [StreamExecutor] Simplify Kernel classes

[Jason Henline via Parallel_libs-commits]

jhen added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/Kernel.h:47
@@ -49,3 +46,3 @@
 ///     using SaxpyKernel =
-///         streamexecutor::TypedKernel<float *, float *, float *>;
+///         streamexecutor::Kernel<float *, float *, float *>;
 ///     } // namespace compiler_cuda_namespace
----------------
jprice wrote:
> Maybe I'm missing something, but should these parameter types actually be `GlobalDeviceMemory<float>`? Otherwise I'm not sure how such a kernel object could be passed to a `thenLaunch()` function with the correct arguments.
You're right. Plus the `A` parameter is usually passed as a `float` not a `float *`. Now the signature should be fixed.


https://reviews.llvm.org/D24043