[Parallel_libs-commits] [PATCH] D23851: [StreamExecutor] Rename Executor to Device

[Justin Lebar via Parallel_libs-commits]

jlebar added inline comments.

================
Comment at: streamexecutor/lib/unittests/DeviceTest.cpp:476
@@ +475,2 @@
+
+} // namespace
----------------
jhen wrote:
> I actually tried to fix this by redoing things with "git mv" to try to clue git in about the change, but it is still showing up as a separate deletion and addition. A little Googling suggests that this will happen if there are too many changes after the move because "git mv" is just an alias for "git rm && git add", so I think that's what happened here.
Oh, I was hoping that git-svn would have something that would let you explicitly say "foo was renamed to bar".  But it sounds like not:

> Renamed and copied directories are not detected by Git and hence not tracked when committing to SVN. I do not plan on adding support for this as it’s quite difficult and time-consuming to get working for all the possible corner cases (Git doesn’t do it, either). Committing renamed and copied files is fully supported if they’re similar enough for Git to detect them.

https://git-scm.com/docs/git-svn

Oh well, not a big deal.


https://reviews.llvm.org/D23851