[Parallel_libs-commits] [PATCH] D23577: [StreamExecutor] Executor add synchronous methods

[Jason Henline via Parallel_libs-commits]

jhen added a comment.

Okay, I've got all the synchronousCopy functions in for all directions (D2H, H2D, D2D) and all the tests are in, so I think this CL is ready for final review.


================
Comment at: streamexecutor/include/streamexecutor/Executor.h:177
@@ +176,3 @@
+      return make_error(
+          "copying too many elements, " + llvm::Twine(ElementCount) +
+          ", from a host array of element count " + llvm::Twine(Src.size()));
----------------
I got rid of most of the comment duplication by referencing earlier functions in the comments for later functions.


https://reviews.llvm.org/D23577