[Parallel_libs-commits] [PATCH] D23577: [StreamExecutor] Executor add synchronous methods

Justin Lebar via Parallel_libs-commits parallel_libs-commits at lists.llvm.org
Mon Aug 22 11:41:40 PDT 2016


jlebar added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/Executor.h:177
@@ +176,3 @@
+    return synchronousCopyD2H(Src.asSlice(), Dst, ElementCount);
+  }
+
----------------
Well, this is a lot of overloads, but I guess it could be worse.  :)

My only thought is that it would be nice not to duplicate so much of the comments.  But other than that, I think you can go forth and do this for real.


https://reviews.llvm.org/D23577





More information about the Parallel_libs-commits mailing list