[Parallel_libs-commits] [PATCH] D23577: [StreamExecutor] Executor add synchronous methods

Justin Lebar via Parallel_libs-commits parallel_libs-commits at lists.llvm.org
Wed Aug 17 08:16:30 PDT 2016


jlebar added a comment.

I had a thought about MemcpyD2H and friends last night.  Not to make you change it again, but it's kind of weird that the function name says "D2H" but the args are (host_ptr, device_ptr).  So long as it's called "memcpy", I think we probably should match memcpy's ordering, but what if we just called it "copy"?

That might somewhat speak to your concern about users getting the order wrong.


https://reviews.llvm.org/D23577





More information about the Parallel_libs-commits mailing list