[Parallel_libs-commits] [PATCH] D23577: [StreamExecutor] Executor add synchronous methods

[Jason Henline via Parallel_libs-commits]

jhen marked 6 inline comments as done.

================
Comment at: streamexecutor/include/streamexecutor/Executor.h:102
@@ +101,3 @@
+    return PExecutor->synchronousMemcpyD2H(DeviceSrc, HostDst.data(),
+                                           ElementCount * sizeof(T));
+  }
----------------
jprice wrote:
> Should be passing `SrcElementOffset * sizeof(T)` through to the platform executor as well now.
Good catch! I promise to write a bunch of unit tests to catch this kind of thing once we have the interface decided.


https://reviews.llvm.org/D23577