[Parallel_libs-commits] [PATCH] D23577: [StreamExecutor] Executor add synchronous methods

[James Price via Parallel_libs-commits]

jprice added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/Executor.h:102
@@ +101,3 @@
+    return PExecutor->synchronousMemcpyD2H(DeviceSrc, HostDst.data(),
+                                           ElementCount * sizeof(T));
+  }
----------------
Should be passing `SrcElementOffset * sizeof(T)` through to the platform executor as well now.

================
Comment at: streamexecutor/include/streamexecutor/Executor.h:135
@@ +134,3 @@
+    return PExecutor->synchronousMemcpyH2D(HostSrc.data(), DeviceDst,
+                                           ElementCount * sizeof(T));
+  }
----------------
Missing offset argument as above.

================
Comment at: streamexecutor/include/streamexecutor/Executor.h:166
@@ +165,3 @@
+    return PExecutor->synchronousMemcpyD2D(DeviceSrc, DeviceDst,
+                                           ElementCount * sizeof(T));
+  }
----------------
Missing offset argument as above.

================
Comment at: streamexecutor/include/streamexecutor/Stream.h:123
@@ -119,3 +122,3 @@
       setError(PExecutor->memcpyD2H(ThePlatformStream.get(), DeviceSrc,
                                     HostDst.data(), ElementCount * sizeof(T)));
     return *this;
----------------
Missing offset argument as above.

================
Comment at: streamexecutor/include/streamexecutor/Stream.h:156
@@ -149,3 +155,3 @@
       setError(PExecutor->memcpyH2D(ThePlatformStream.get(), HostSrc.data(),
                                     DeviceDst, ElementCount * sizeof(T)));
     return *this;
----------------
Missing offset argument as above.

================
Comment at: streamexecutor/include/streamexecutor/Stream.h:187
@@ -176,3 +186,3 @@
       setError(PExecutor->memcpyD2D(ThePlatformStream.get(), DeviceSrc,
                                     DeviceDst, ElementCount * sizeof(T)));
     return *this;
----------------
Missing offset argument as above.


https://reviews.llvm.org/D23577