[Parallel_libs-commits] [PATCH] D23333: [StreamExecutor] Add basic Stream operations

[Jason Henline via Parallel_libs-commits]

jhen added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/PlatformInterfaces.h:45
@@ +44,3 @@
+  explicit PlatformStreamHandle(
+      PlatformStreamExecutor *ParentExecutor = nullptr)
+      : ParentExecutor(ParentExecutor) {}
----------------
jlebar wrote:
> Why do we allow a null executor?
This was to allow a default construction followed by a call to `setParentExecutor`. It's removed now because it is not needed since I moved the responsibility of setting the executor pointer to the platform-specific implementation (as per jlebar's comment below).


https://reviews.llvm.org/D23333