[Parallel_libs-commits] [PATCH] D23333: [StreamExecutor] Add basic Stream operations

[Jason Henline via Parallel_libs-commits]

jhen added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/PlatformInterfaces.h:60
@@ +59,3 @@
+  /// Destroys the given stream.
+  virtual void deallocateStream(Stream *S) = 0;
+
----------------
jprice wrote:
> Should there be a corresponding platform-specific `allocateStream()`?
Really good point. In response, I changed this part of the design. Now there is a `PlatformStream` base class that is responsible for cleaning up its resources during destruction, so there is no more `deallocateStream` method.

I also changed the methods in `PlatformStreamExecutor` to accept `PlatformStream` pointers rather than `Stream` pointers. This seems to fit better with the design of having the Platform class methods take raw handles rather than public wrappers.


https://reviews.llvm.org/D23333