[Parallel_libs-commits] [PATCH] D23333: [StreamExecutor] Add basic Stream operations

[James Price via Parallel_libs-commits]

jprice added a comment.

I think I understand the motivation for restricting the use of `StreamExecutor::launch/memcpy` etc to only the `Stream` class via the `StreamKey` struct, but I'm not sure I see the need for the `StreamExecutorKey` struct. It seems like this is currently just protecting the `Stream` constructor, but is it really a problem if someone can write `new Stream(Executor, nullptr)` as well as `Executor->createStream()`? Don't have strong opinions about this, just curious.

The `StreamExecutor` class seems to be missing a virtual destructor (warned by Clang).


https://reviews.llvm.org/D23333