[Parallel_libs-commits] [PATCH] D23138: [StreamExecutor] Add kernel types

Jason Henline via Parallel_libs-commits parallel_libs-commits at lists.llvm.org
Thu Aug 4 10:07:16 PDT 2016


jhen added inline comments.

================
Comment at: streamexecutor/lib/Kernel.cpp:42
@@ +41,3 @@
+                      std::move(*MaybeImplementation));
+  return Instance;
+}
----------------
jprice wrote:
> This needed a `std::move()` for me to build with GCC 5 on Ubuntu or Apple Clang on OS X.
Thanks for spotting this jprice. I can confirm that it fails to build with GCC 4.8 on Ubuntu as well without the `std::move()`. I have now added the `std::move()` to prevent this error.


https://reviews.llvm.org/D23138





More information about the Parallel_libs-commits mailing list