[Openmp-dev] LIT failure: clang/test/Driver/openmp-offload-gpu.c

[Shilei Tian via Openmp-dev]

I guess your X86 platform doesn’t have CUDA installed. This issue will not be exposed if the system doesn’t have CUDA. I’ll submit a patch.

Regards,
Shilei

> On Mar 18, 2021, at 5:43 PM, Kelvin Li <kli at ca.ibm.com> wrote:
> 
> One more data point.  I repeated the builds on the x86 platform.  With LLVM_TARGETS_TO_BUILD="X86", the test is "UNSUPPORTED" (as expected).  With LLVM_TARGETS_TO_BUILD="ALL", the test actually ran and passed.
>  
> Thanks,
> Kelvin
>  
>  
> ----- Original message -----
> From: Shilei Tian <tianshilei1992 at gmail.com>
> To: Joachim Protze <protze.joachim at gmail.com>
> Cc: Kelvin Li <kli at ca.ibm.com>, openmp-dev at lists.llvm.org
> Subject: [EXTERNAL] Re: [Openmp-dev] LIT failure: clang/test/Driver/openmp-offload-gpu.c
> Date: Thu, Mar 18, 2021 17:24
>  
> There is dummy file in clang/test/Driver/Inputs/libomptarget. It also has multiple dummy CUDAs. For this specific case, it should not raise the error because passing -S should only contain preprocess and compilation.
>  
> Regards,
> Shilei
>  
>> 
>> On Mar 18, 2021, at 5:19 PM, Joachim Protze <protze.joachim at gmail.com <mailto:protze.joachim at gmail.com>> wrote:
>>  
>> The test complains, that libomptarget-nvptx-sm_60.bc cannot be found.
>> How should it be found, if libomptarget is not built?
>> 
>> - Joachim
>> 
>> Am 18.03.21 um 22:16 schrieb Shilei Tian:
>>> 
>>> It’s clang driver test, so it doesn’t need to have OpenMP enabled. On Phab, IIRC, by default it’s ALL. I did remember I updated the patch because of the driver case, and later it all passed.
>>> 
>>> Regards,
>>> Shilei
>>>  
>>>> 
>>>> On Mar 18, 2021, at 5:14 PM, Joachim Protze <protze.joachim at gmail.com <mailto:protze.joachim at gmail.com>> wrote:
>>>> 
>>>> The REQUIRES lines at the top of the file specify, that all targets need
>>>> to be available so that the test is supported.
>>>> 
>>>> To fulfill the dependency with the bitcode library, this should be added
>>>> as another REQUIREment of the test.
>>>> 
>>>> I assume that phabricator and your local test builds include building
>>>> the OpenMP runtime/project?
>>>> 
>>>> - Joachim
>>>> 
>>>> 
>>>> Am 18.03.21 um 21:38 schrieb Shilei Tian via Openmp-dev:
>>>>> 
>>>>> Hi Kelvin,
>>>>> 
>>>>> If only building with target PPC, this case will not be run because clang cannot process CUDA code.
>>>>> I think it’s related to our recent change that the bitcode library is required when building OpenMP program so I updated the driver. However it passed the test before (locally and on Phab). I’ll try to reproduce and fix it accordingly.
>>>>> 
>>>>> Regards,
>>>>> Shilei
>>>>>  
>>>>>> 
>>>>>> On Mar 18, 2021, at 3:14 PM, Kelvin Li via Openmp-dev <openmp-dev at lists.llvm.org <mailto:openmp-dev at lists.llvm.org>> wrote:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> I don't know the LIT test infrastructure well enough.  Recently, openmp-offload-gpu.c started to fail in our downstream test.  I find that if I build with LLVM_TARGETS_TO_BUILD="PowerPC", the test is "UNSUPPORTED".  If I build with LLVM_TARGETS_TO_BUILD="ALL", the test fails.  In both cases, NO -DLLVM_ENABLE_RUNTIMES="openmp" is specified in the cmake command
>>>>>> 
>>>>>> Any clues of the reason?
>>>>>> 
>>>>>> The error message:
>>>>>> 
>>>>>> Exit Code: 1
>>>>>> Command Output (stderr):
>>>>>> --
>>>>>> llvm-project/clang/test/Driver/openmp-offload-gpu.c:150:25: error: CHK-NOLIBDEVICE-NOT: excluded string found in input
>>>>>> // CHK-NOLIBDEVICE-NOT: error:{{.*}}sm_60
>>>>>>                       ^
>>>>>> <stdin>:6:8: note: found here
>>>>>> clang: error: No library 'libomptarget-nvptx-sm_60.bc' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-nvptx-bc-path to specify nvptx bitcode library.
>>>>>>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>>> 
>>>>>> Kelvin
>>>>>> 
>>>>>> _______________________________________________
>>>>>> Openmp-dev mailing list
>>>>>> Openmp-dev at lists.llvm.org <mailto:Openmp-dev at lists.llvm.org>
>>>>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev <https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_openmp-2Ddev&d=DwQFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=yebGUrvFJWJ7GtM9woczVA&m=yn9zy059XfSjYVLwKsM9SSxIsdiVF5fbAHwujOzxde0&s=j6cqZBFu5n5meaovjrIcLKjJb7D_kT0JhAVJCz3EQNM&e=>
>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> Openmp-dev mailing list
>>>>> Openmp-dev at lists.llvm.org <mailto:Openmp-dev at lists.llvm.org>
>>>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev <https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_openmp-2Ddev&d=DwQFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=yebGUrvFJWJ7GtM9woczVA&m=yn9zy059XfSjYVLwKsM9SSxIsdiVF5fbAHwujOzxde0&s=j6cqZBFu5n5meaovjrIcLKjJb7D_kT0JhAVJCz3EQNM&e=>
>>>>>  
>>> 
>>>  
> 
>  
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20210318/cea45cbc/attachment-0001.html>