[Openmp-dev] accidental interface change for __kmpc_push_target_tripcount?

[Deepak Eachempati via Openmp-dev]

Hi,

It looks like we broke backwards compatibility for the __kmpc_push_target_tripcount with this change that added location fields to libomptarget for debugging:

https://reviews.llvm.org/D87946<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D87946&d=DwMFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=Bh22sFI6-VGL2UQadI-dH9OCPAYb99YwOEfNc6F-8oM&m=SyOKtEnH3HhBUfOSnL8HmCuVsRpPnKnAR1mvsAZUBQs&s=opcC_EdBFuDypMkCLTeZ5VMPwpNPovZy0IpkZivJ7IQ&e=>

>From the discussion in the patch review, a suffix (like _loc) was not added for the new Mapper API entry points because they weren't released in Clang 11.x. But __kmpc_push_target_tripcount was an existing entry point. I suspect this was just overlooked?

Do we have time to get this fixed for Clang 12.x, by adding a new __kmpc_push_target_tripcount_loc?

Thanks,
Deepak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20210308/cf68c1ba/attachment.html>