[Openmp-dev] LIT. tests for OpenMPOpt

[Abid Malik via Openmp-dev]

Thanks.

My understanding is that all the tests available in test/Transform/OpenMP/*
should pass. However, I tried and some are failing. E.g.,
pararllel_deletion.ll is failing. Just want to confirm if I might be doing
something wrong.

On Mon, Jan 25, 2021 at 10:57 AM Michael Kruse <llvm at meinersbur.de> wrote:

> Am Mo., 25. Jan. 2021 um 08:11 Uhr schrieb Abid Malik via Openmp-dev
> <openmp-dev at lists.llvm.org>:
> > 1) Why running. opt twice on some parallel region tests?
> > ; RUN: opt -S -attributor -openmpopt  < %s | FileCheck %s
> > ; RUN: opt -S -passes='attributor,cgscc(openmpopt)'  < %s | FileCheck %s
>
> The first line is testing with the legacy pass manager (at least this
> was the idea at some point, with EXPERIMENTAL_NEW_PASS_MANAGER=ON flag
> it tries to use the new pass manager even when using the legacy pass
> manager command line interface), the latter with the new pass manager.
> It is typical to have multiple run lines to run the same test input
> with different options.
>
> > 2) Why we are not using -O3 flag? does -openmpopt flag enough for
> OpenMPOpt?
>
> -O3 would add many other passes to the pass manager, but this test is
> meant to only test the attributor. Add unrelated passes would render
> the test very flaky as any change of these could cause this test to
> fail.
>
> Testing with -O3 would be more akin to an end-to-end test, which is
> what we do with the llvm-test-suite.
>
> > 3) It does not print any text or statement for debugging
>
> Tests are not supposed to check debug output. Debug output is meant to
> help to find an issue, i.e humans-readable, whereas regression tests
> only check the (machine-readable) output. To get more detailed debug
> output, you might want to add more LLVM_DEBUG(dbgs() << ...) which, if
> checked in regression tests, would cause tests to break.
>
> Unfortunately we do have many tests that also check debug output.
>
>
> Michael
>


-- 
Abid M. Malik
******************************************************
"I have learned silence from the talkative, toleration from the intolerant,
and kindness from the unkind"---Gibran
"Success is not for the chosen few, but for the few who choose" --- John
Maxwell
"Being a good person does not depend on your religion or status in life,
your race or skin color, political views or culture. IT DEPENDS ON HOW GOOD
YOU TREAT OTHERS"--- Abid
"The Universe is talking to us, and the language of the Universe is
mathematics."----Abid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20210125/cdb587b5/attachment.html>