[Openmp-dev] Small nit on # endif changes

[Hahnfeld, Jonas via Openmp-dev]

Hi,

Although your message was really hard to understand I think I finally got it: You mean the additional whitespace between '#' and 'endif', right?
(to which commit or patch are you referring?)

I think this should be fine, even GCC in traditional mode will do it right:
"Preprocessing directives are recognized only when their leading ‘#’ appears in the first column. There can be no whitespace between the beginning of the line and the ‘#’, but whitespace can follow the ‘#’."
(from https://gcc.gnu.org/onlinedocs/cpp/Traditional-miscellany.html#Traditional-miscellany, note the last 'but')

Greetings,
Jonas

> -----Original Message-----
> From: Openmp-dev [mailto:openmp-dev-bounces at lists.llvm.org] On Behalf
> Of C Bergström via Openmp-dev
> Sent: Friday, June 17, 2016 12:02 AM
> To: openmp-dev
> Subject: [Openmp-dev] Small nit on # endif changes
> 
> I'm not 100% certain if old cpp will accept this fwiw. I vaguely remember
> some discussion on comp.compilers about this.
> 
> I also don't really like this style.. so if anyone doesn't feel strongly or if it was
> an error please put it back
> ----------------
> 
> 
>  -#endif /*
> +# endif /*
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20160617/339b5d6f/attachment.bin>