[Openmp-dev] Cross compiler build fix [Important]

[Peyton, Jonathan L]

I think this patch will work.  It offers a new option -DLIBIOMP_COPY_EXPORTS=true(default)|false
If you specify "false", then absolutely no copying is done anywhere after the library is built.

This patch applies on top of this change:
1fd47b8 Change some text areas from saying Intel(R) OpenMP runtime library to LLVM OpenMP runtime library.

-- Johnny

-----Original Message-----
From: C Bergström [mailto:cbergstrom at pathscale.com] 
Sent: Tuesday, May 12, 2015 3:30 PM
To: Peyton, Jonathan L
Cc: openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] Cross compiler build fix [Important]

Yeah that works - I just need a way to disable this.

The testsuite should also be fixed to not depend on this. Since apparently the lib name may be changing and imho depending on it like this isn't clean.

The testsuite should ideally take a parameter - -DPATH_TO_OMP_RUNTIME If we roll with a name change - it should pull the same variable as what was used in my patch from the other day.

On Wed, May 13, 2015 at 3:22 AM, Peyton, Jonathan L <jonathan.l.peyton at intel.com> wrote:
> The one problem we have is that the testsuite expects libiomp5.so and omp.h to be in the openmp/runtime/exports/ directory.  Is it ok if we add something like -DLIBIOMP_NO_EXPORTS=true?
>
> -- Johnny
>
> -----Original Message-----
> From: openmp-dev-bounces at cs.uiuc.edu 
> [mailto:openmp-dev-bounces at cs.uiuc.edu] On Behalf Of C Bergström
> Sent: Tuesday, May 12, 2015 2:31 PM
> To: openmp-dev at dcs-maillist2.engr.illinois.edu
> Subject: Re: [Openmp-dev] Cross compiler build fix [Important]
>
> *bump* the other patch was sent after my other one and hasn't been reviewed. It should be trivial and is important to our cross compiler buildbot.
>
> Thanks
>
> On Sun, May 10, 2015 at 5:07 PM, C Bergström <cbergstrom at pathscale.com> wrote:
>> I sent a patch before that removed unnecessary copies and it was 
>> rejected without a 2nd review. I'm attaching a slightly revised 
>> approach which is hopefully ok for the Intel people. I realize I may 
>> be the only one currently doing cross compiles of the library, but I 
>> feel strongly this is important to do in a clean way. (source and 
>> build dir seperate)
>
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at dcs-maillist2.engr.illinois.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cross_compile_support.patch
Type: application/octet-stream
Size: 9180 bytes
Desc: cross_compile_support.patch
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150512/9d0ad218/attachment.obj>