[Openmp-dev] testsuite script error

Mon May 11 11:25:33 PDT 2015

I've attached a patch which I believe fixes both these issues.  I have to wait till Andrey is in the office to get this committed.

-- Johnny

-----Original Message-----
From: Hahnfeld, Jonas [mailto:Hahnfeld at itc.rwth-aachen.de] 
Sent: Monday, May 11, 2015 10:04 AM
To: Peyton, Jonathan L; Carlo Bertolli; Sunita Chandrasekaran
Cc: openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: RE: [Openmp-dev] testsuite script error

Hi,

This is clearly a problem, the header file should only be generated if needed 
and the fix looks good (maybe just appending "ompt.h" if needed would be 
enough...)

But this is only one half of the solution: The file "ompt.h.var" is missing 
for OpenMP 4.1 (with CMake: make[2]: *** No rule to make target 
`../src/include/41/ompt.h.var', needed by `ompt.h'.  Stop.)
Could you please fix this as well?

Greets,
Jonas

From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-bounces at cs.uiuc.edu] 
On Behalf Of Peyton, Jonathan L
Sent: Friday, May 08, 2015 10:33 PM
To: Peyton, Jonathan L; Carlo Bertolli; Sunita Chandrasekaran
Cc: openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] testsuite script error

Here is the fix.

diff --git a/runtime/src/makefile.mk b/runtime/src/makefile.mk
index c3af993..8acdf44 100644
--- a/runtime/src/makefile.mk
+++ b/runtime/src/makefile.mk
@@ -877,9 +877,16 @@ out_lib_files  = $(addprefix $(out_lib_dir),$(lib_file) 
$(imp_file) $(pdb_file)
out_inc_files  = $(addprefix $(out_ptf_dir)include_compat/,iomp_lib.h)
out_mod_files  = \
     $(addprefix $(out_ptf_dir)include/,omp_lib.mod omp_lib_kinds.mod)
+ifeq "$(OMPT_SUPPORT)" "on"
out_cmn_files  = \
     $(addprefix $(out_cmn_dir)include/,omp.h ompt.h omp_lib.h omp_lib.f 
omp_lib.f90) \
     $(addprefix $(out_cmn_dir)include_compat/,iomp.h)
+else
+out_cmn_files  = \
+    $(addprefix $(out_cmn_dir)include/,omp.h omp_lib.h omp_lib.f omp_lib.f90) 
\
+    $(addprefix $(out_cmn_dir)include_compat/,iomp.h)
+endif
+
ifneq "$(out_lib_fat_dir)" ""
     out_lib_fat_files  = $(addprefix $(out_lib_fat_dir),$(lib_file) 
$(imp_file))
endif

I don't have commit rights so you'll have to apply this manually until Monday.

-- Johnny

From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-bounces at cs.uiuc.edu] 
On Behalf Of Peyton, Jonathan L
Sent: Friday, May 8, 2015 3:25 PM
To: Carlo Bertolli; Sunita Chandrasekaran
Cc: openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] testsuite script error

That's not a problem with the testsuite; it is a problem with our makefile.  I'll 
take a look at it.

-- Johnny

From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-bounces at cs.uiuc.edu] 
On Behalf Of Carlo Bertolli
Sent: Friday, May 8, 2015 3:11 PM
To: Sunita Chandrasekaran
Cc: openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] testsuite script error

Hi

Thanks for the quick answer.

Running "make test" in openmp/runtime on a x86 machine returns this error:

make[1]: *** No rule to make target 
`/gsa/yktgsa/projects/l/llvm-coral-build/repos/ppc64le/libiomp/runtime/exports/common/include/ompt.h', 
needed by `common'.  Stop.

Still doing something wrong apparently, and I cannot figure out where that 
file comes from.

Thanks!

-- Carlo

Sunita Chandrasekaran ---05/08/2015 03:58:04 PM---Hi Carlo If you could simply 
use 'make test' from openmp/runtime folder, that is all

From: Sunita Chandrasekaran <sunita at cs.uh.edu>
To: Carlo Bertolli/Watson/IBM at IBMUS
Cc: "openmp-dev at dcs-maillist2.engr.illinois.edu" 
<openmp-dev at dcs-maillist2.engr.illinois.edu>, Millad Ghane 
<millad.mg at gmail.com>
Date: 05/08/2015 03:58 PM
Subject: Re: [Openmp-dev] testsuite script error
Sent by: sunisg123 at gmail.com
________________________________________



Hi Carlo

If you could simply use 'make test' from openmp/runtime folder, that is all 
that is needed.

Sorry if the 2 READMEs are creating a confusion.

Please drop us a note, if you have further issues.

Thanks
Sunita
P.S: Copied is our Ph.D. student here at UH.

On Fri, May 8, 2015 at 2:27 PM, Carlo Bertolli <cbertol at us.ibm.com> wrote:
Hi all

After fetching the latest version of the library from here:

origin http://llvm.org/git/openmp.git (fetch)


I started seeing the following error when I run "make ctest" in the testsuite 
directory:

Testing for "has_openmp":
Generating sources ..........Could not open the sourcefile for the main 
program ompts_standaloneProc.c at ./template_parser_c.pl line 51.
Could not open the sourcefile for the main program ompts_standaloneProc.c at 
./template_parser_c.pl line 51.
ERROR: Generation of sourcecode for the test failed.
ERROR: Generation of sourcecode for the crosstest failed.
.... failed

for all tests. This happens equally on an Intel machine and a PCC64LE one.

What am I doing wrong?


Thanks

-- Carlo

_______________________________________________
Openmp-dev mailing list
Openmp-dev at dcs-maillist2.engr.illinois.edu
http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: build_fixes.patch
Type: application/octet-stream
Size: 25155 bytes
Desc: build_fixes.patch
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150511/1befda9e/attachment.obj>
