[Openmp-dev] suppress more unused-variable and unused-function warnings

[Jack Howarth]

On Sun, Jun 7, 2015 at 3:21 PM, C Bergström <cbergstrom at pathscale.com> wrote:
> Are these false warnings? I think clang should be fixed. Is there a
> ticket on this?
> -                kmp_task_team_t * task_team = this_thr->th.th_task_team;
> +                kmp_task_team_t * task_team;
> +                task_team = this_thr->th.th_task_team;
>
>
> I'd like to keep the c90 style instead of c99
> -    int f;
>

C,
     If you search for instances of...

grep -R int * | grep for | grep " = " | grep "\+\+"

in openmp, you will find that the C99 syntax is already widely used so
this seems to be a moot point unless all those are going to be
reversed as well.
           Jack

>
> On Mon, Jun 8, 2015 at 12:22 AM, Jack Howarth
> <howarth.mailing.lists at gmail.com> wrote:
>> Jonathan,
>>       The attached patch eliminates most of the unused-variable and
>> unused-function warnings during the cmake build of openmp on
>> x86_64-apple-darwin14. The resulting build shows no regressions in the
>> OpenMP3.1_Validation test suite at -m64 or -m32.
>>                  Jack
>> ps The remaining instances fall in three main categories...
>>
>> 1) instances of "warning: unused variable 'temp_val'
>> [-Wunused-variable]" from runtime/src/kmp_atomic.c
>>
>> 2) instances of "warning: unused variable '__kmp_build_check_*'
>> [-Wunused-variable]" from runtime/src/kmp_itt.inl,
>> runtime/src/kmp_itt.c, runtime/src/kmp_global.c and
>> runtime/src/kmp_dispatch.cpp.
>>
>> 3) instances of "warning: unused function '__kmp_x86_pause'
>> [-Wunused-function]" from runtime/src/kmp.h
>>
>> _______________________________________________
>> Openmp-dev mailing list
>> Openmp-dev at dcs-maillist2.engr.illinois.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev
>>