[Openmp-dev] KMP_IOMP_NAME

[Peyton, Jonathan L]

I've been burned on this before.  When editing the en_US.txt message catalog file, you can't delete lines because of the way some data structures and enum's are generated (see the generated files kmp_i18n_default.inc and kmp_i18n_id.inc after you build).  You have to put OBSOLETE in place of the name.  So I could do:

OBSOLETE          "You may want to use an %1$s library that supports %2$s interface with version %3$s."
and
OBSOLETE          "You may want to use an %1$s library with version %2$s."

-- Johnny

-----Original Message-----
From: Jack Howarth [mailto:howarth.mailing.lists at gmail.com] 
Sent: Tuesday, June 2, 2015 2:00 PM
To: Churbanov, Andrey
Cc: Peyton, Jonathan L; openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] KMP_IOMP_NAME

Jonathan,
      It appears that...

GetNewerIOMPLibrary          "You may want to use an %1$s library that
supports %2$s interface with version %3$s."

and

GetNewerIRMLLibrary          "You may want to use an %1$s library with
version %2$s."

are dead code in runtime/src/i18n/en_US.txt and can be removed as well.
         Jack

On Tue, Jun 2, 2015 at 1:29 PM, Jack Howarth <howarth.mailing.lists at gmail.com> wrote:
> Andrey,
>      I've been wondering how much dead-code got dragged in with the 
> bulk merge of the openmp tree (since there really wasn't the normal 
> code-review during that process). Perhaps just as important as adding 
> more OpenMP 4.x support would be going through the openmp codebase and 
> making sure dead legacy code from earlier versions of iomp has been 
> purged out.
>           Jack
>
> On Tue, Jun 2, 2015 at 12:15 PM, Churbanov, Andrey 
> <Andrey.Churbanov at intel.com> wrote:
>> I think it is better to remove unused things rather than rename.
>>
>> - Andrey
>>
>>> -----Original Message-----
>>> From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev- 
>>> bounces at cs.uiuc.edu] On Behalf Of Jack Howarth
>>> Sent: Tuesday, June 02, 2015 7:08 PM
>>> To: Peyton, Jonathan L; openmp-dev at dcs-maillist2.engr.illinois.edu
>>> Subject: [Openmp-dev] KMP_IOMP_NAME
>>>
>>> Jonathan,
>>>       What is the definition of...
>>>
>>> #define KMP_IOMP_NAME       "Intel(R) OMP"
>>>
>>> in runtime/src/kmp.h used for? I don't see any usages within the 
>>> current openmp and cfe sources. If it needs to be retained, should't it be transformed into...
>>>
>>> #define KMP_OMP_NAME       "LLVM* OMP"
>>>
>>>        Jack
>>> _______________________________________________
>>> Openmp-dev mailing list
>>> Openmp-dev at dcs-maillist2.engr.illinois.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev
>>
>> --------------------------------------------------------------------
>> Closed Joint Stock Company Intel A/O
>> Registered legal address: Krylatsky Hills Business Park,
>> 17 Krylatskaya Str., Bldg 4, Moscow 121614, Russian Federation
>>
>> This e-mail and any attachments may contain confidential material for 
>> the sole use of the intended recipient(s). Any review or distribution 
>> by others is strictly prohibited. If you are not the intended 
>> recipient, please contact the sender and delete all copies.
>>