[Openmp-dev] Getting Architecture Patch

[Peyton, Jonathan L]

Carlo,

I have applied your patch on top of the most recent changes (Intel® MIC changes), and also added a few changes:

diff --git a/runtime/CMakeLists.txt b/runtime/CMakeLists.txt
Got rid of this deletion of AARCH64
set(INTEL64 FALSE)
set(ARM FALSE)
-set(AARCH64 FALSE)
+set(PPC64BE FALSE)
+set(PPC64LE FALSE)

diff --git a/runtime/src/kmp_os.h b/runtime/src/kmp_os.h
Got rid of this deletion of AARCH64
-#define KMP_ARCH_PPC64      0
-#define KMP_ARCH_AARCH64    0
+#define KMP_ARCH_X86_64     0

In makefile.mk, I added a few places where I feel it should be checking for both ppc64 and ppc64le, you can see this in the attached patch file.

Check this out and see if it is correct.
To apply the patch on clean updated repository:
$ patch -p0 < ppc64le-support-v2.patch

-- Johnny

From: Carlo Bertolli [mailto:cbertol at us.ibm.com]
Sent: Thursday, January 15, 2015 11:00 PM
To: C Bergström
Cc: Cownie, James H; Peyton, Jonathan L; openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: Getting Architecture Patch


Hi

Did now see that one - I removed it in the attached version. Let me know if I broke something.


(See attached file: ppc64le-support.patch)

Thanks

-- Carlo

[Inactive hide details for C Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP]C Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP_ARCH_X86_64     0

From: C Bergström <cbergstrom at pathscale.com<mailto:cbergstrom at pathscale.com>>
To: Carlo Bertolli/Watson/IBM at IBMUS
Cc: "Peyton, Jonathan L" <jonathan.l.peyton at intel.com<mailto:jonathan.l.peyton at intel.com>>, "Cownie, James H" <james.h.cownie at intel.com<mailto:james.h.cownie at intel.com>>, "openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>" <openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>>
Date: 01/15/2015 11:53 PM
Subject: Re: Getting Architecture Patch

________________________________



A whitespace change snuck in at here (extra tab)

+#define KMP_ARCH_X86_64     0

Otherwise the patch is probably in align with the intention
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150117/90f3bb73/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 105 bytes
Desc: image001.gif
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150117/90f3bb73/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ppc64le-support-v2.patch
Type: application/octet-stream
Size: 10899 bytes
Desc: ppc64le-support-v2.patch
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150117/90f3bb73/attachment.obj>