[Openmp-dev] More cmake breakage

[Hahnfeld, Jonas via Openmp-dev]

It doesn't matter anymore now that it's committed, but my point was that 'configure_file' doesn't need the absolute path with the current binary directory.
This isn't consistent with the other calls in this file and the CMake documentation says:
> If <output> is a relative path it is evaluated with respect to the current binary directory.
Sorry if that was unclear: The fix itself was needed, the build was indeed broken!

Greetings,
Jonas

> -----Original Message-----
> From: Churbanov, Andrey [mailto:Andrey.Churbanov at intel.com]
> Sent: Monday, August 31, 2015 11:42 AM
> To: C Bergstrom; Hahnfeld, Jonas; Hans Wennborg
> Cc: LLVM-OpenMP (openmp-dev at lists.llvm.org)
> Subject: RE: [Openmp-dev] More cmake breakage
> 
> I've committed the patch, svn revision 246426.
> 
> Thanks,
> Andrey
> 
> > -----Original Message-----
> > From: Openmp-dev [mailto:openmp-dev-bounces at lists.llvm.org] On
> Behalf
> > Of C Bergstrom via Openmp-dev
> > Sent: Monday, August 31, 2015 9:42 AM
> > To: Hahnfeld, Jonas; Hans Wennborg
> > Cc: LLVM-OpenMP (openmp-dev at lists.llvm.org)
> > Subject: Re: [Openmp-dev] More cmake breakage
> >
> > I'm fairly certain that's needed as well. Someone please push this and
> > we can back out that piece if it breaks anything for anyone else or
> > figure out the correct way later.
> >
> > Thanks
> >
> > On Mon, Aug 31, 2015 at 1:35 PM, Hahnfeld, Jonas <Hahnfeld at itc.rwth-
> > aachen.de> wrote:
> > > The changes were part of this review that was posted more than a
> > > week
> > > ago: http://reviews.llvm.org/D12211 I must admit that I didn't check
> > > the
> > Fortran build...
> > >
> > > The proposed patch looks good to me, but I think that the
> > CMAKE_CURRENT_BINARY_DIR isn't needed for configure_file (it at least
> > works for me without).
> > >
> > >> -----Original Message-----
> > >> From: Openmp-dev [mailto:openmp-dev-bounces at lists.llvm.org] On
> > >> Behalf Of C Bergström via Openmp-dev
> > >> Sent: Monday, August 31, 2015 6:59 AM
> > >> To: openmp-dev
> > >> Subject: Re: [Openmp-dev] More cmake breakage
> > >>
> > >> Attached patch should fix this
> > >> ---------
> > >> Hal or whoever decides this - I'd like to request commit access.
> > >> When the corporate people break stuff on a Friday afternoon I'd
> > >> like to be able to fix it over the weekend.
> > _______________________________________________
> > Openmp-dev mailing list
> > Openmp-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
> 
> --------------------------------------------------------------------
> Closed Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614, Russian Federation
> 
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact the
> sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150831/aba595ed/attachment-0001.bin>