[Openmp-dev] Minor change request

Peyton, Jonathan L via Openmp-dev openmp-dev at lists.llvm.org
Fri Aug 21 08:10:33 PDT 2015


In kmp_platform.h (which is included in z_Linux_asm.s) there is this definition of KMP_OS_DARWIN:

#if ( defined __APPLE__ && defined __MACH__ ) 
# undef KMP_OS_DARWIN 
# define KMP_OS_DARWIN 1 
#endif

I changed it because it is cleaner and it is consistent with the rest of the code.

-- Johnny

-----Original Message-----
From: Openmp-dev [mailto:openmp-dev-bounces at lists.llvm.org] On Behalf Of C Bergström via Openmp-dev
Sent: Thursday, August 20, 2015 11:50 PM
To: openmp-dev at lists.llvm.org
Subject: [Openmp-dev] Minor change request

A recent change did this
---------
-# if defined __APPLE__ && defined __MACH__
+# if KMP_OS_DARWIN
---------

While it looks slightly better - The original code is slightly preferred. Is iOS identified as DARWIN or how would we handle that?

Was this changed to be consistent or why?
_______________________________________________
Openmp-dev mailing list
Openmp-dev at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev


More information about the Openmp-dev mailing list