[Openmp-dev] [PATCH] [Revisedx2] Initial cmake support

[Alp Toker]

On 02/06/2014 20:10, Andrey Bokhanko wrote:
> Alp,
>
> I understand your emotions, but let us stick to the facts, not invent 
> them.
>
> There is nothing hostile or arrogant in my mail towards you -- you 
> still have my respect as an active member of llvm (and now libiomp 
> :-)) community.

:-)

>
> However, stating that you
>
>     technically the *top committer* on the LLVM openmp module given
>     that the "code drop" commit was monolithic),
>
>
> is simply bending the truth

Both statements I made there are truthful, and they were meant as mildly 
embarrassing commentary rather than a boast.

A good way to change the situation is to participate in on-list code 
review like everyone else and make a few commits. I note that despite 
all the discussion, there is still no alternative implementation posted 
to the public list.


> and doesn't give you enough authority to approve significant changes 
> to the project. Sorry.

Pretty sure it does, and others too.

http://llvm.org/docs/DeveloperPolicy.html

And besides, the CMake change doesn't introduce any change in 
functionality. As such, it's hardly a significant change in the sense a 
codegen or logic change would be.

These are text files that can be amended and improved with basic review, 
so let's go ahead and do that when you're ready to submit patches?


>
> Finally,
>
> $ git log --author=Andrey
>
>     commit c88ab54e0d3d89c97175d21d6af3466df5445eaa
>     Author: Andrey Churbanov <Andrey.Churbanov at intel.com
>     <mailto:Andrey.Churbanov at intel.com>>
>     Date:   Thu Oct 3 07:27:25 2013 +0000
>
>         typo fixed as a test commit
>
>
> This is another Andrey. He works at Intel as well, but no relation to me.

Well, that drives the point home.

We've been maintaining the OpenMP runtime codebase here as part of the 
LLVM project and I look forward to helping review your changes, as I 
hope you'll come to review those of others with time.

I'm glad that there's an abundance of energy and opinions in a module 
that's been characterised by silence since October 2013 and we should 
work towards our shared goals :-)

Alp.


>
> Andrey
> (Bokhanko, not Churbanov)
>

-- 
http://www.nuanti.com
the browser experts