[Openmp-dev] [PATCH] [Revisedx2] Initial cmake support

[Andrey Bokhanko]

Hal,

To which message are you referring?
>

This one:
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2014-June/000146.html

To be fair, this is a bit different. First, as I've explained, you don't
> need approval from the code owner, you need approval from some established
> contributor who is knowledgeable in that part of the code, including
> design, implementation details and future direction (and, in effect, who is
> willing to take responsibility for your change). The problem you have with
> many of the OpenMP patches is that only the code owners are in such a
> position, but please don't over-generalize. There are many more qualified
> people for build system changes (although, FWIW, not as many as one might
> think). Please understand that, as far as we could tell, the future
> direction (CMake) was clear, and so Alp had all of the knowledge he needed
> to approve the commit.
>

Agree -- no two things are exactly the same.

Said this, do you think reviewing and committing a new build system on a
weekend, with no chance to have a review with project architect is a good
and collaborative approach?

Really?

Andrey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20140602/79f1dab9/attachment.html>