[Openmp-dev] [PATCH] [Revisedx2] Initial cmake support

[Cownie, James H]

Sorry, I am going to revert this check in.

* You are moving too fast; all of this has been done since noon on Friday here in the UK, 
  and I was out on Friday afternoon and do not work at weekends. I have therefore had no chance to 
  look at it before it was checked in. (And I'm supposed to be a key reviewer and architect here...)

* A change like this (which provides a whole new build system) requires more than one review.

* Since everyone complained so much, we have been working on a CMAKE based build system here at Intel 
  that we hope to push this week, which *does* support Windows, icc, gcc, clang etc

So, at the point when I commit that, I'm going to remove these changes.

By all means give me grief and complain about your wasted time. There's not a lot I can do about it, though.

-- Jim

James Cownie <james.h.cownie at intel.com>
SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)
Tel: +44 117 9071438


-----Original Message-----
From: Alp Toker [mailto:alp at nuanti.com] 
Sent: Sunday, June 01, 2014 7:15 PM
To: Jack Howarth; openmp-dev at dcs-maillist2.engr.illinois.edu; Cownie, James H; "C. Bergström"
Subject: Re: [Openmp-dev] [PATCH] [Revisedx2] Initial cmake support


On 01/06/2014 15:04, Jack Howarth wrote:
> Initial cmake support for openmp patch with CMAKE_CXX_COMPILER hack 
> removed as requested. Tested on x86_64-apple-darwin12 against the 
> system clang compilers from Xcode 5.1.1 and on x86_64 Fedora 15 
> against the system gcc 4.6.3 compilers.

LGTM. Landed in r209994!

Note that I've split out a CMakeLists.txt that includes the one in src, and updated the documentation in README.txt explaining that the CMake system is experimental and not supported for production builds.

There's still some work to get this up and running on Windows, FreeBSD, icc, and the configuration needs to be made more flexible but it's a great start. I'd also like to check in with Jim to make sure this works with the Intel setup at some point.

Thanks Jack and C. Bergström for the initial contribution.

Alp.





>
>
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at dcs-maillist2.engr.illinois.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev

--
http://www.nuanti.com
the browser experts

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.