[Openmp-dev] Two independent patches to the source code

Peyton, Jonathan L jonathan.l.peyton at intel.com
Mon Dec 15 15:31:33 PST 2014


We have received criticism for large, monolithic commits instead of creating smaller independent patches.  We have taken this criticism into consideration and now have some small independent patches ready for review.

1) hier_barrier_fix.patch - This patch has a couple small fixes to the hierarchical barrier, predominately used on the Intel(r) MIC Architecture, in the context of teams and infinite blocktime.  The value of 0 for nesting level is used in the parallel region that consists of the team masters, and hierarchical barrier did not take that into consideration.

2) balanced_affinity.patch - This patch enables the use of KMP_AFFINITY=balanced on non-MIC Architectures.  The restriction for using balanced affinity on non-MIC architectures is it only works for one-package machines.

To apply the patches:
Put them in the directory that contatins offload/, runtime/, etc.
>$ patch -p0 < hier_barrier_fix.patch
>$ patch -p0 < balanced_affinity.patch

Please leave feedback!

-- Johnny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20141215/3a9051bf/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hier_barrier_fix.patch
Type: application/octet-stream
Size: 1216 bytes
Desc: hier_barrier_fix.patch
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20141215/3a9051bf/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: balanced_affinity.patch
Type: application/octet-stream
Size: 8724 bytes
Desc: balanced_affinity.patch
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20141215/3a9051bf/attachment-0001.obj>


More information about the Openmp-dev mailing list