[Openmp-dev] New OpenMP runtime release

["C. Bergström"]

On 12/24/13 04:58 AM, Steven Noonan wrote:
> On Mon, Dec 23, 2013 at 05:36:04PM +0000, Cownie, James H wrote:
>> For your Christmas hacking pleasure.
>>
>> This release aligns with Intel(r) Composer XE 2013 SP1 Product Update 2
>>
>> New features
>> * The library can now be built with clang (though with some
>>    limitations since clang does not support 128 bit floats, so the library built with
>>    clang cannot be used with a different compiler that does have such support.)
>> * Support for Vtune analysis of load imbalance
>> * Code contribution from Steven Noonan to build the runtime for ARM*
>>    architecture processors
> Cool. Thanks, Jim!
>
> It looks like there's still a minor correction that needs to happen. I
> didn't get an opportunity to test the merged changes until they went
> public, and there's actually a compile error in there now:
>
> 	../../src/z_Linux_asm.s: Assembler messages:
> 	../../src/z_Linux_asm.s:1590: Error: junk at end of line, first unrecognized character is `,'
>
> With a quick bit of Googling, I found this:
>
>      http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=422971
>
> In that bug report's comments, Daniel Jacobowitz clarifies that '@' is
> an ARM comment marker, so using '%' is the preferred annotation. I've
> compile and run-tested this on both x86_64 and ARM, and both work at
> this point:
>
> diff --git a/runtime/src/z_Linux_asm.s b/runtime/src/z_Linux_asm.s
> index 1f1ba1b..bba3b14 100644
> --- a/runtime/src/z_Linux_asm.s
> +++ b/runtime/src/z_Linux_asm.s
> @@ -1587,5 +1587,5 @@ __kmp_unnamed_critical_addr:
>
>
>   #if defined(__linux__)
> -.section .note.GNU-stack,"", at progbits
> +.section .note.GNU-stack,"",%progbits
>   #endif
That change is almost certainly incorrect (we've had to fix that same 
problem in libunwind and openblas before)

Take a look at this and see if something similar works for you
https://github.com/xianyi/OpenBLAS/blob/develop/driver/others/memory.c

OpenBLAS/driver/others/memory.c:  asm 
("\t.section\t.ctors,\"aw\", at progbits; .align 8; .quad gotoblas_init; 
.section .text");

If you really can't support this for some crazy reason then please hide 
it further under an ARM specific #if

Thanks