[Openmp-commits] [openmp] [openmp] Add support for arm64ec to libomp (PR #176151)

[Martin Storsjö via Openmp-commits]

mstorsjo wrote:

> The problem with having the C function call the assembly function is getting the exit thunks generated for all the possible function signatures for the function pointer.
> 
> So I guess we have two choices here: we could XFAIL the test and accept that more than 15 arguments will never work, or we could call the assembly function from this C implementation when there are more than 15 arguments and accept that that will crash if the function pointer came from x86... there's not really another way to do it unfortunately, at least not that I can think of.

Right, I see. As some architectures do have the 15 argument limit already (e.g. 32 bit ARM had it up until a few years ago), I believe that limit isn't too much of an actual issue (although I have no real world experience of OpenMP, so I don't know what's used and what's not) , so I would go with this approach with the C wrapper and an XFAIL, as that's more correct arm64ec wise.

https://github.com/llvm/llvm-project/pull/176151