[Openmp-commits] [llvm] [openmp] [Offload][OMPT] Properly implement `ompt_get_target_info` (PR #202392)

[via Openmp-commits]

Jan =?utf-8?q?André?= Reuter <jan at zyten.de>,
Jan =?utf-8?q?André?= Reuter <j.reuter at fz-juelich.de>,
Jan =?utf-8?q?André?= Reuter <j.reuter at fz-juelich.de>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/202392 at github.com>


================
@@ -77,6 +78,20 @@ static uint64_t createRegionId() {
   return NewId;
 }
 
+static int ompt_get_target_info_impl(uint64_t *DeviceNum, ompt_id_t *TargetId,
+                                     ompt_id_t *HostOpId) {
+  if (RegionInterface.getTargetDataValue() == ompt_id_none)
----------------
jprotze wrote:

The function should return 1 while liboffload on the thread is busy with the target region. TargetData is not necessarily set by a sampling tool. With #175165, checking for OmptTaskInfoPtr!=nullptr might be more reliable.

https://github.com/llvm/llvm-project/pull/202392