[Openmp-commits] [openmp] [libomp] Add kmp_str_ref (ADT 1/2) (PR #176162)

[Shilei Tian via Openmp-commits]

shiltian wrote:

I'm not really a fan of reinventing the wheel when it is not necessary. `libomp` is a C library. Are we going to reimplement features that exist in C++ just to make the code look more like C++? This also applies to the other PR that tries to introduce another ADT.

Whether `std::string_view` stays header-only should not be a problem right now. If in the future it is not, and we still want to keep `libomp` as a C library, then we can come back and reinvent the wheel if needed, because at that point there would be no real alternative.

I would explore this option first. If it does not work out, then we can add our own implementation.

https://github.com/llvm/llvm-project/pull/176162