[Openmp-commits] [openmp] [OpenMP][omptest] Improve CMake and address review comments (PR #159416)

[LLVM Continuous Integration via Openmp-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-latest-gcc` running on `linaro-flang-aarch64-latest-gcc` while building `openmp` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/130/builds/17318

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
270.784 [124/15/729] Building CXX object openmp/runtime/src/CMakeFiles/obj.omp.dir/kmp_taskdeps.cpp.o
270.817 [124/14/730] Generating python-module/ompd/__init__.py
270.858 [124/13/731] Building CXX object openmp/runtime/src/CMakeFiles/obj.omp.dir/kmp_settings.cpp.o
271.517 [124/12/732] Building CXX object openmp/runtime/src/CMakeFiles/obj.omp.dir/kmp_affinity.cpp.o
271.710 [124/11/733] Building C object openmp/libompd/gdb-plugin/CMakeFiles/ompdModule.dir/ompdAPITests.c.o
271.900 [124/10/734] Building C object openmp/libompd/gdb-plugin/CMakeFiles/ompdModule.dir/ompdModule.c.o
272.087 [124/9/735] Building CXX object openmp/libompd/src/CMakeFiles/ompd.dir/omp-debug.cpp.o
273.163 [124/8/736] Building CXX object openmp/libompd/src/CMakeFiles/ompd.dir/omp-icv.cpp.o
273.217 [122/9/737] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptAssertEvent.cpp.o
273.223 [122/8/738] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o
FAILED: openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o 
/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/./bin/clang++ --target=aarch64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Domptest_EXPORTS -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/runtimes/runtimes-bins/openmp/runtime/src -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/openmp/tools/omptest/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -fcolor-diagnostics -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-extra -Wno-pedantic -fno-semantic-interposition -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=default -UNDEBUG -MD -MT openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o -MF openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o.d -o openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/openmp/tools/omptest/src/OmptTester.cpp
In file included from /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/openmp/tools/omptest/src/OmptTester.cpp:17:
In file included from /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/openmp/tools/omptest/include/OmptTester.h:49:
/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/openmp/tools/omptest/include/OmptTesterGoogleTest.h:27:10: fatal error: 'gtest/gtest.h' file not found
   27 | #include "gtest/gtest.h"
      |          ^~~~~~~~~~~~~~~
1 error generated.
273.391 [122/7/739] Linking C shared module openmp/libompd/gdb-plugin/python-module/ompd/ompdModule.so
273.526 [122/6/740] Building CXX object openmp/libompd/src/CMakeFiles/ompd.dir/TargetValue.cpp.o
273.629 [122/5/741] Linking C shared library openmp/runtime/src/libomp.so
273.877 [122/4/742] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/Logging.cpp.o
273.886 [122/3/743] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptCallbackHandler.cpp.o
275.198 [122/2/744] Building CXX object flang-rt/lib/runtime/CMakeFiles/flang_rt.runtime.static.dir/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/flang/lib/Decimal/binary-to-decimal.cpp.o
275.431 [122/1/745] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptAsserter.cpp.o
ninja: build stopped: subcommand failed.
FAILED: runtimes/runtimes-stamps/runtimes-build /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/runtimes/runtimes-stamps/runtimes-build 
cd /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/159416