[Openmp-commits] [openmp] [OpenMP][omptest] Improve CMake and address review comments (PR #159416)

[LLVM Continuous Integration via Openmp-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `openmp` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/33432

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[23/45] Generating OffloadAPI.h
[24/38] Linking CXX shared library /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libomptarget.so.23.0git
[25/38] Creating library symlink /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libomptarget.so
[26/38] Generating /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/compile_commands.json
[27/38] Linking CXX shared library /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libLLVMOffload.so.23.0git
[28/38] Creating library symlink /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libLLVMOffload.so
[29/38] Linking CXX executable /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-omp-kernel-replay
[30/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/InternalEventOperators.cpp.o
[31/38] Linking CXX executable /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-offload-device-info
[32/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o
FAILED: openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o 
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Domptest_EXPORTS -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/runtimes/runtimes-bins/openmp/runtime/src -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -fcolor-diagnostics -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-extra -Wno-pedantic -fno-semantic-interposition -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=default -UNDEBUG -MD -MT openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o -MF openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o.d -o openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/src/OmptTester.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/src/OmptTester.cpp:17:
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/include/OmptTester.h:49:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/include/OmptTesterGoogleTest.h:27:10: fatal error: 'gtest/gtest.h' file not found
   27 | #include "gtest/gtest.h"
      |          ^~~~~~~~~~~~~~~
1 error generated.
[33/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptAssertEvent.cpp.o
[34/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/Logging.cpp.o
[35/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptCallbackHandler.cpp.o
[36/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/InternalEvent.cpp.o
[37/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptAsserter.cpp.o
ninja: build stopped: subcommand failed.
[8432/8435] Completed 'runtimes-amdgcn-amd-amdhsa'
FAILED: runtimes/runtimes-stamps/runtimes-build /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/runtimes/runtimes-stamps/runtimes-build 
cd /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.
['ninja'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 62, in step
    yield
  File "../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 53, in main
    run_command(["ninja"])
  File "../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 75, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd
    subprocess.check_call(cmd, shell=shell, *args, **kwargs)
  File "/usr/lib64/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja']' returned non-zero exit status 1.
@@@STEP_FAILURE@@@
Step 7 (build cmake config) failure: build cmake config (failure)
...
[23/45] Generating OffloadAPI.h
[24/38] Linking CXX shared library /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libomptarget.so.23.0git
[25/38] Creating library symlink /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libomptarget.so
[26/38] Generating /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/compile_commands.json
[27/38] Linking CXX shared library /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libLLVMOffload.so.23.0git
[28/38] Creating library symlink /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/libLLVMOffload.so
[29/38] Linking CXX executable /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-omp-kernel-replay
[30/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/InternalEventOperators.cpp.o
[31/38] Linking CXX executable /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/bin/llvm-offload-device-info
[32/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o
FAILED: openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o 
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Domptest_EXPORTS -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/runtimes/runtimes-bins/openmp/runtime/src -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -fcolor-diagnostics -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-extra -Wno-pedantic -fno-semantic-interposition -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=default -UNDEBUG -MD -MT openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o -MF openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o.d -o openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptTester.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/src/OmptTester.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/src/OmptTester.cpp:17:
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/include/OmptTester.h:49:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/openmp/tools/omptest/include/OmptTesterGoogleTest.h:27:10: fatal error: 'gtest/gtest.h' file not found
   27 | #include "gtest/gtest.h"
      |          ^~~~~~~~~~~~~~~
1 error generated.
[33/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptAssertEvent.cpp.o
[34/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/Logging.cpp.o
[35/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptCallbackHandler.cpp.o
[36/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/InternalEvent.cpp.o
[37/38] Building CXX object openmp/tools/omptest/CMakeFiles/omptest.dir/src/OmptAsserter.cpp.o
ninja: build stopped: subcommand failed.
[8432/8435] Completed 'runtimes-amdgcn-amd-amdhsa'
FAILED: runtimes/runtimes-stamps/runtimes-build /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/runtimes/runtimes-stamps/runtimes-build 
cd /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.
['ninja'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 62, in step
    yield
  File "../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 53, in main
    run_command(["ninja"])
  File "../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py", line 75, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd
    subprocess.check_call(cmd, shell=shell, *args, **kwargs)
  File "/usr/lib64/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja']' returned non-zero exit status 1.
program finished with exit code 0
elapsedTime=502.218994

```

</details>

https://github.com/llvm/llvm-project/pull/159416