[Openmp-commits] [clang] [llvm] [openmp] [OpenMP] support for Emissary APIs as discussed in 89169 (PR #175265)

[via Openmp-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/lib/CodeGen/CGEmitEmissaryExec.cpp clang/lib/Headers/EmissaryIds.h clang/lib/Headers/EmissaryMPI.h offload/plugins-nextgen/common/include/Emissary.h offload/plugins-nextgen/common/src/Emissary.cpp offload/plugins-nextgen/common/src/EmissaryFortrt.cpp offload/plugins-nextgen/common/src/EmissaryPrint.cpp openmp/device/src/EmissaryFortrt.cpp openmp/device/src/EmissaryPrint.cpp clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Headers/llvm_libc_wrappers/stdio.h offload/include/Shared/RPCOpcodes.h offload/plugins-nextgen/common/src/RPC.cpp openmp/device/src/Misc.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Headers/EmissaryIds.h b/clang/lib/Headers/EmissaryIds.h
index f9ff616a0..3c38f3d24 100644
--- a/clang/lib/Headers/EmissaryIds.h
+++ b/clang/lib/Headers/EmissaryIds.h
@@ -33,8 +33,8 @@ typedef enum {
 /// The vargs function used by emissary API device stubs
 unsigned long long _emissary_exec(unsigned long long, ...);
 
-//#define _PACK_EMIS_IDS(x, y)                                                   \
-//  ((unsigned long long)x << 32) | ((unsigned long long)y)
+// #define _PACK_EMIS_IDS(x, y) \
+//   ((unsigned long long)x << 32) | ((unsigned long long)y)
 
 #define _PACK_EMIS_IDS(a, b, c, d)                                             \
   ((unsigned long long)a << 48) | ((unsigned long long)b << 32) |              \
diff --git a/offload/plugins-nextgen/common/src/Emissary.cpp b/offload/plugins-nextgen/common/src/Emissary.cpp
index 0be0e426e..063e1aafe 100644
--- a/offload/plugins-nextgen/common/src/Emissary.cpp
+++ b/offload/plugins-nextgen/common/src/Emissary.cpp
@@ -196,7 +196,7 @@ EmissaryBuildVargs(int NumArgs, char *keyptr, char *dataptr, char *strptr,
       if (numbits == 1) { // This is a pointer to string
         num_bytes = 4;
         bytes_consumed = num_bytes;
-        strsz = (size_t) * (unsigned int *)dataptr;
+        strsz = (size_t)*(unsigned int *)dataptr;
         if ((*data_not_used) < bytes_consumed)
           return _ERC_DATA_USED_ERROR;
         a[argcount] = (emis_argptr_t *)((char *)strptr);
diff --git a/offload/plugins-nextgen/common/src/EmissaryPrint.cpp b/offload/plugins-nextgen/common/src/EmissaryPrint.cpp
index 80c55d3c5..88d92b327 100644
--- a/offload/plugins-nextgen/common/src/EmissaryPrint.cpp
+++ b/offload/plugins-nextgen/common/src/EmissaryPrint.cpp
@@ -276,7 +276,7 @@ static service_rc emissary_pfBuildValist(emissary_ValistExt_t *valist,
       if (numbits == 1) { // This is a pointer to string
         num_bytes = 4;
         bytes_consumed = num_bytes;
-        strsz = (size_t) * (unsigned int *)dataptr;
+        strsz = (size_t)*(unsigned int *)dataptr;
         if ((*data_not_used) < bytes_consumed)
           return _ERC_DATA_USED_ERROR;
         if (emissary_pfAddString(valist, (char *)&strptr, strsz, &stacksize))
@@ -355,7 +355,7 @@ static service_rc emissary_fprintf(uint *rc, emisArgBuf_t *ab) {
   // Skip past the format string
   ab->NumArgs--;
   ab->keyptr += 4;
-  size_t abstrsz = (size_t) * (unsigned int *)ab->argptr;
+  size_t abstrsz = (size_t)*(unsigned int *)ab->argptr;
   ab->strptr += abstrsz;
   ab->argptr += 4;
   ab->data_not_used -= 4;
@@ -389,7 +389,7 @@ static service_rc emissary_printf(uint *rc, emisArgBuf_t *ab) {
   // Skip past the format string
   ab->NumArgs--;
   ab->keyptr += 4;
-  size_t abstrsz = (size_t) * (unsigned int *)ab->argptr;
+  size_t abstrsz = (size_t)*(unsigned int *)ab->argptr;
   ab->strptr += abstrsz;
   ab->argptr += 4;
   ab->data_not_used -= 4;
diff --git a/offload/plugins-nextgen/common/src/RPC.cpp b/offload/plugins-nextgen/common/src/RPC.cpp
index c3f041aa2..947498263 100644
--- a/offload/plugins-nextgen/common/src/RPC.cpp
+++ b/offload/plugins-nextgen/common/src/RPC.cpp
@@ -112,13 +112,13 @@ rpc::Status handleOffloadOpcodes(plugin::GenericDeviceTy &Device,
         for (uint32_t idx = 0; idx < ab->NumSendXfers; idx++) {
           numSendXfers++;
           devXfers[id] = (void *)*((uint64_t *)ab->argptr);
-          XferSzs[id] = (size_t) * ((size_t *)(ab->argptr + sizeof(void *)));
+          XferSzs[id] = (size_t)*((size_t *)(ab->argptr + sizeof(void *)));
           emisSkipXferArgSet(ab);
         }
         // Allocate the host space for the receive Xfers
         for (uint32_t idx = 0; idx < ab->NumRecvXfers; idx++) {
           void *devAddr = (void *)*((uint64_t *)ab->argptr);
-          size_t devSz = (size_t) * ((size_t *)(ab->argptr + sizeof(void *)));
+          size_t devSz = (size_t)*((size_t *)(ab->argptr + sizeof(void *)));
           void *hostAddr = new char[devSz];
           D2HAddrList.insert(std::pair<void *, void *>(devAddr, hostAddr));
           emisSkipXferArgSet(ab);
@@ -174,7 +174,7 @@ rpc::Status handleOffloadOpcodes(plugin::GenericDeviceTy &Device,
           void *devAddr = (void *)*((uint64_t *)ab->argptr);
           recvXfers[id] = D2HAddrList[devAddr];
           recvXferSzs[id] =
-              (uint64_t) * ((size_t *)(ab->argptr + sizeof(void *)));
+              (uint64_t)*((size_t *)(ab->argptr + sizeof(void *)));
           emisSkipXferArgSet(ab);
         }
         id++;
diff --git a/openmp/device/src/Misc.cpp b/openmp/device/src/Misc.cpp
index fc300d60e..77f9815dd 100644
--- a/openmp/device/src/Misc.cpp
+++ b/openmp/device/src/Misc.cpp
@@ -174,7 +174,7 @@ unsigned long long __llvm_emissary_rpc_dm(uint32_t sz32, void *bufdata) {
   for (uint32_t idx = 0; idx < NumSendXfers; idx++) {
     void *D2Hdata = (void *)*((uint64_t *)argptr);
     argptr += sizeof(void *);
-    size_t D2Hsize = (size_t) * ((size_t *)argptr);
+    size_t D2Hsize = (size_t)*((size_t *)argptr);
     argptr += sizeof(size_t);
     Port.send_n(D2Hdata, D2Hsize);
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/175265