[Openmp-commits] [llvm] [openmp] [offload][openmp] - Remove standalone build in favor of 'runtimes' (PR #170693)

[Michael Kruse via Openmp-commits]

Meinersbur wrote:

> How is it supposed to work? FWICS `llvm_gtest` target requires `find_package(LLVM)` to succeed but the runtimes CMakeLists has only:
> 
> ```
> find_package(LLVM PATHS "${LLVM_BINARY_DIR}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH)
> ```
> 
> which cannot succeed because `LLVM_BINARY_DIR` is empty and `NO_DEFAULT_PATH` suppresses any way to specify the correct path.

For `llvm_gtest` specifically, it should use `default_gtest` instead. It either uses `llvm_gtest` if the find_package(LLVM) has found a build tree, an install tree if `LLVM_INSTALL_GTREST=ON`, or `runtimes_gtest` in an LLVM_ENABLE_RUNTIMES build, which adds thirdparty/googletest itself. Also see #159416.


https://github.com/llvm/llvm-project/pull/170693