[Openmp-commits] [openmp] [OpenMP][omptest] Improve CMake and address review comments (PR #159416)
Martin Storsjö via Openmp-commits
openmp-commits at lists.llvm.org
Fri Feb 27 09:26:00 PST 2026
mstorsjo wrote:
> IIRC, the two commits "just" create the infrastructure to write the actual runtime tests. That means, backporting these commits will not improve test coverage for libomp.
It's not about improving test coverage, it's about making tests work at all, if built in the runtimes build mode. Currently, if building in the runtimes build mode and try to run tests, one runs into the errors mentioned in https://github.com/llvm/llvm-project/pull/159416#issuecomment-3723476041.
Therefore, we'd need to backport this commit to fix that.
Then looking at this commit on its own, it seems to have broken a bunch of buildbots, with https://github.com/llvm/llvm-project/pull/176802 fixing them. So if backporting this one, the other one needs to go along with it, no?
https://github.com/llvm/llvm-project/pull/159416
More information about the Openmp-commits
mailing list