[Openmp-commits] [openmp] [openmp] - Remove hwloc INSTALL_INTERFACE on omp target (PR #218923)
via Openmp-commits
openmp-commits at lists.llvm.org
Wed Aug 26 06:56:39 PDT 2026
https://github.com/estewart08 created https://github.com/llvm/llvm-project/pull/218923
Reasons for removal:
1. hwloc is not present in installed headers, therefore a consumer of openmp does not need hwloc
2. There is no omp target exported currently, which means INSTALL_INTERFACE is ignored.
3. If there is a future omp target exported then there is a possible relocation issue if LIBOMP_HWLOC_INCLUDE_DIR differs in build environment vs end user's environment.
We need to keep BUILD_INTERFACE for unit testing and ompd build.
Originally introduced in https://reviews.llvm.org/D123888
>From 21bb75c82912208eab8a28d11932334beb0b3d10 Mon Sep 17 00:00:00 2001
From: Ethan Stewart <ethan.stewart at amd.com>
Date: Wed, 26 Aug 2026 08:35:05 -0500
Subject: [PATCH] [openmp] - Remove hwloc INSTALL_INTERFACE on omp target
Reasons for removal:
1. hwloc is not present in installed headers, therefore a consumer of openmp does not need hwloc
2. There is no omp target exported currently, which means INSTALL_INTERFACE is ignored.
3. If there is a future omp target exported then there is a possible relocation issue
if LIBOMP_HWLOC_INCLUDE_DIR differs in build environment vs end user's environment.
We need to keep BUILD_INTERFACE for unit testing and ompd build.
Originally introduced in https://reviews.llvm.org/D123888
---
openmp/runtime/src/CMakeLists.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/openmp/runtime/src/CMakeLists.txt b/openmp/runtime/src/CMakeLists.txt
index 69def2b03b1b4..d39d318ba2446 100644
--- a/openmp/runtime/src/CMakeLists.txt
+++ b/openmp/runtime/src/CMakeLists.txt
@@ -201,11 +201,9 @@ if(LIBOMP_USE_HWLOC)
target_include_directories(obj.omp
PRIVATE
"$<BUILD_INTERFACE:${LIBOMP_HWLOC_INCLUDE_DIR}>"
- "$<INSTALL_INTERFACE:${LIBOMP_HWLOC_INCLUDE_DIR}>")
target_include_directories(omp
INTERFACE
"$<BUILD_INTERFACE:${LIBOMP_HWLOC_INCLUDE_DIR}>"
- "$<INSTALL_INTERFACE:${LIBOMP_HWLOC_INCLUDE_DIR}>")
endif()
if(OPENMP_MSVC_NAME_SCHEME)
More information about the Openmp-commits
mailing list