[Openmp-commits] [openmp] [libomp] Add kmp_str_ref (ADT 1/2) (PR #176162)

[Robert Imschweiler via Openmp-commits]

================

----------------
ro-i wrote:

Hm, but what would be the purpose? While for `__kmp_basic_str_to_int` (which is included in `kmp.h` thanks to include of `kmp_str.h` in `kmp.h`, there is a separate definition in `kmp_str.cpp`, if we forward declare `__kmp_allocate`, then we still need to have an include at some other point in the translation unit, right? Because `kmp.h` contains the definition of `__kmp_allocate`, not only the declaration. And thanks to the include guard, `kmp.h` is not included multiple times, anyway.
So, wouldn't the forward declaration create more confusion / potentially issues?

https://github.com/llvm/llvm-project/pull/176162