[Openmp-commits] [openmp] Draft: [OpenMP] Fix td_tdg_task_id underflow with taskloop and taskgraph (PR #150877)
Josep Pinot via Openmp-commits
openmp-commits at lists.llvm.org
Tue Sep 9 02:51:54 PDT 2025
jpinot wrote:
> I think, the number of places where you iterate over all records is limited. In these places, you could simply check for `record_map[i].task != NULL` and skip the spurious holes in the vector of records. In other places where the record map is used to find successors, you can still blindly access the map entries.
Thank you for the feedback and sorry for the delayed response.
I agree that allowing spurious holes in the `record_map` simplifies the logic. I’ve updated the branch to incorporate your suggestion. I’ve also added the extra locking mechanism for resizing `record_map` and `successors`, and removed the premature allocation of `successors`. My preliminary tests have been successful.
@jprotze, what are your thoughts?
https://github.com/llvm/llvm-project/pull/150877
More information about the Openmp-commits
mailing list