[Openmp-commits] [openmp] [OpenMP][test] Make %p 0x prefix optional (PR #138514)

Michael Klemm via Openmp-commits openmp-commits at lists.llvm.org
Fri May 9 22:48:48 PDT 2025


mjklemm wrote:

> > Can you please have a look and see why the code formatter has failed?
> 
> I've tried to run `clang-format-diff.py` on the patch before creating the PR, but that failed miserably. As you can see in the `clang-format` changes suggested on the PR page, this introduces arbitrary reformattings and line breaks that totally mess up the `FileCheck` annotations. ISTM that `clang-format` and `FileCheck` simply don't match at all: you have to leave e.g. long lines as is. And given the size and mechanical nature of the patch, manual reformatting is simply impractical.

Thanks for checking.  I agree with your sentiment that applying these changes would be too much. 

https://github.com/llvm/llvm-project/pull/138514


More information about the Openmp-commits mailing list