[Openmp-commits] [openmp] [OpenMP] Provide __kmp_unnamed_critical_addr on SPARC (PR #138517)

[Sharjeel Khan via Openmp-commits]

Sharjeel-Khan wrote:

This change caused a slight error in Android's CI:
```
[5/35] Building ASM object runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o
FAILED: runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o 
/b/f/w/src/git/out/stage2-install/bin/clang --sysroot=/b/f/w/src/git/out/sysroots/platform/arm  -I/b/f/w/src/git/out/lib/libomp-arm-static/runtime/src -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/i18n -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/include -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/thirdparty/ittnotify -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/android -ffile-prefix-map=/b/f/w/src/git/= --target=armv7a-linux-androideabi30 -ffunction-sections -fdata-sections -march=armv7-a -D_LIBCPP_AVAILABILITY_HAS_NO_VERBOSE_ABORT=1 --sysroot=/b/f/w/src/git/out/sysroots/platform/arm -O3 -DNDEBUG -fPIC   -D _GNU_SOURCE -D _REENTRANT -D LIBOMP_HAVE_PTHREAD_SETNAME_NP -U_GLIBCXX_ASSERTIONS -MD -MT runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o -MF runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o.d -o runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o -c /b/f/w/src/git/out/llvm-project/openmp/runtime/src/z_Linux_asm.S
/[b/f/w/src/git/out/llvm-project/openmp/runtime/src/z_Linux_asm.S:2485](https://cs.corp.google.com/piper///depot/google3/b/f/w/src/git/out/llvm-project/openmp/runtime/src/z_Linux_asm.S?l=2485):39: error: expected STT_<TYPE_IN_UPPER_CASE>, '#<type>', '%<type>' or "<type>"
    .type __kmp_unnamed_critical_addr, at object
```

I want to make sure this error is a mistake from our build scripts or the change.

https://github.com/llvm/llvm-project/pull/138517