[Openmp-commits] [openmp] [OpenMP] Address __kmp_dist_for_static_init issue (PR #129902)

[Sergio Afonso via Openmp-commits]

skatrak wrote:

Thank you @jprotze for the explanation. The problem with @hansangbae's solution is that for some reason it does still not fix the issue in this case, as I shared previously. Also, replacing the assert with your suggestion on its own doesn't stop it from asserting either, because `team->t.t_serialized=1` in this case.

The example you shared where my patch would break is, as far as I understand, invalid OpenMP. This is because `teams` regions must be strictly nested within the implicit parallel region surrounding the whole program or a `target` region (5.2: 232, 5-6). So it doesn't look like it could fail in that way. But maybe I'm just misunderstanding this, so let me know.

It can imagine it's possible that the bug is elsewhere in the runtime or the sequence of runtime calls is somehow incorrect and we're reaching the call to `__kmp_dist_for_static_init` in an invalid state, that's why I created the gist. That way it's easier to at least evaluate the second point and to debug the first.

https://github.com/llvm/llvm-project/pull/129902