[Openmp-commits] [openmp] Draft: Update OpenMP runtime to adopt taskgraph clause from 6.0 Specs (PR #130751)
Josep Pinot via Openmp-commits
openmp-commits at lists.llvm.org
Tue Mar 11 07:29:37 PDT 2025
https://github.com/jpinot updated https://github.com/llvm/llvm-project/pull/130751
>From 7f788d7b727713d1dade6306b5cf44058b8a38d7 Mon Sep 17 00:00:00 2001
From: jpinot <josep.pinot at bsc.es>
Date: Tue, 11 Mar 2025 14:30:49 +0100
Subject: [PATCH 1/3] [OpenMP] Fix task record/replay comments
---
openmp/runtime/src/kmp_tasking.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/openmp/runtime/src/kmp_tasking.cpp b/openmp/runtime/src/kmp_tasking.cpp
index 3e229b517cfcd..6cc0d47e0b4c1 100644
--- a/openmp/runtime/src/kmp_tasking.cpp
+++ b/openmp/runtime/src/kmp_tasking.cpp
@@ -5454,7 +5454,6 @@ bool __kmpc_omp_has_task_team(kmp_int32 gtid) {
#if OMPX_TASKGRAPH
// __kmp_find_tdg: identify a TDG through its ID
-// gtid: Global Thread ID
// tdg_id: ID of the TDG
// returns: If a TDG corresponding to this ID is found and not
// its initial state, return the pointer to it, otherwise nullptr
@@ -5507,7 +5506,7 @@ void __kmp_print_tdg_dot(kmp_tdg_info_t *tdg, kmp_int32 gtid) {
KA_TRACE(10, ("__kmp_print_tdg_dot(exit): T#%d tdg_id=%d \n", gtid, tdg_id));
}
-// __kmp_start_record: launch the execution of a previous
+// __kmp_exec_tdg: launch the execution of a previous
// recorded TDG
// gtid: Global Thread ID
// tdg: ID of the TDG
>From 357073522a5f6272bb30e017b8914201a0ecbd25 Mon Sep 17 00:00:00 2001
From: jpinot <josep.pinot at bsc.es>
Date: Mon, 10 Mar 2025 12:18:25 +0100
Subject: [PATCH 2/3] [OpenMP] Fix tdg_id in task record and replay mechanism
Previously, tdg_id was used as an array index and an id for the task replay
and record mechanism, but to adder to the OpenMP 6.0 specifications it
should be trated uniquly as a id. This makes the mechanism fully
compliant with OpenMP 6.0 graph_id clause without breaking
compatibility.
With this change, tdg_id more accurately represents an opaque
identifier, accommodating the scenario where the compiler generates a
hashed ID that accounts for the region/graph ID.
---
openmp/runtime/src/kmp.h | 2 +-
openmp/runtime/src/kmp_global.cpp | 3 +-
openmp/runtime/src/kmp_tasking.cpp | 78 +++++++++++++++++++-----------
3 files changed, 53 insertions(+), 30 deletions(-)
diff --git a/openmp/runtime/src/kmp.h b/openmp/runtime/src/kmp.h
index 36656325be4bd..7e415a8ec9888 100644
--- a/openmp/runtime/src/kmp.h
+++ b/openmp/runtime/src/kmp.h
@@ -2650,7 +2650,7 @@ typedef struct kmp_tdg_info {
extern int __kmp_tdg_dot;
extern kmp_int32 __kmp_max_tdgs;
extern kmp_tdg_info_t **__kmp_global_tdgs;
-extern kmp_int32 __kmp_curr_tdg_idx;
+extern kmp_tdg_info_t *__kmp_curr_tdg;
extern kmp_int32 __kmp_successors_size;
extern std::atomic<kmp_int32> __kmp_tdg_task_id;
extern kmp_int32 __kmp_num_tdg;
diff --git a/openmp/runtime/src/kmp_global.cpp b/openmp/runtime/src/kmp_global.cpp
index 52e0fdbdfb1da..7b6bfff7c54ea 100644
--- a/openmp/runtime/src/kmp_global.cpp
+++ b/openmp/runtime/src/kmp_global.cpp
@@ -554,8 +554,7 @@ int *__kmp_nesting_nth_level;
int __kmp_tdg_dot = 0;
kmp_int32 __kmp_max_tdgs = 100;
kmp_tdg_info_t **__kmp_global_tdgs = NULL;
-kmp_int32 __kmp_curr_tdg_idx =
- 0; // Id of the current TDG being recorded or executed
+kmp_tdg_info_t *__kmp_curr_tdg = NULL; // Current TDG being recorded or executed
kmp_int32 __kmp_num_tdg = 0;
kmp_int32 __kmp_successors_size = 10; // Initial succesor size list for
// recording
diff --git a/openmp/runtime/src/kmp_tasking.cpp b/openmp/runtime/src/kmp_tasking.cpp
index 6cc0d47e0b4c1..ab82dbae7cb63 100644
--- a/openmp/runtime/src/kmp_tasking.cpp
+++ b/openmp/runtime/src/kmp_tasking.cpp
@@ -1651,11 +1651,11 @@ kmp_task_t *__kmp_task_alloc(ident_t *loc_ref, kmp_int32 gtid,
}
#if OMPX_TASKGRAPH
- kmp_tdg_info_t *tdg = __kmp_find_tdg(__kmp_curr_tdg_idx);
+ kmp_tdg_info_t *tdg = __kmp_curr_tdg;
if (tdg && __kmp_tdg_is_recording(tdg->tdg_status) &&
(task_entry != (kmp_routine_entry_t)__kmp_taskloop_task)) {
taskdata->is_taskgraph = 1;
- taskdata->tdg = __kmp_global_tdgs[__kmp_curr_tdg_idx];
+ taskdata->tdg = tdg;
taskdata->td_task_id = KMP_ATOMIC_INC(&__kmp_tdg_task_id);
}
#endif
@@ -2576,14 +2576,11 @@ without help of the runtime library.
*/
void *__kmpc_task_reduction_init(int gtid, int num, void *data) {
#if OMPX_TASKGRAPH
- kmp_tdg_info_t *tdg = __kmp_find_tdg(__kmp_curr_tdg_idx);
+ kmp_tdg_info_t *tdg = __kmp_curr_tdg;
if (tdg && __kmp_tdg_is_recording(tdg->tdg_status)) {
- kmp_tdg_info_t *this_tdg = __kmp_global_tdgs[__kmp_curr_tdg_idx];
- this_tdg->rec_taskred_data =
- __kmp_allocate(sizeof(kmp_task_red_input_t) * num);
- this_tdg->rec_num_taskred = num;
- KMP_MEMCPY(this_tdg->rec_taskred_data, data,
- sizeof(kmp_task_red_input_t) * num);
+ tdg->rec_taskred_data = __kmp_allocate(sizeof(kmp_task_red_input_t) * num);
+ tdg->rec_num_taskred = num;
+ KMP_MEMCPY(tdg->rec_taskred_data, data, sizeof(kmp_task_red_input_t) * num);
}
#endif
return __kmp_task_reduction_init(gtid, num, (kmp_task_red_input_t *)data);
@@ -2603,14 +2600,11 @@ has two parameters, pointer to object to be initialized and pointer to omp_orig
*/
void *__kmpc_taskred_init(int gtid, int num, void *data) {
#if OMPX_TASKGRAPH
- kmp_tdg_info_t *tdg = __kmp_find_tdg(__kmp_curr_tdg_idx);
+ kmp_tdg_info_t *tdg = __kmp_curr_tdg;
if (tdg && __kmp_tdg_is_recording(tdg->tdg_status)) {
- kmp_tdg_info_t *this_tdg = __kmp_global_tdgs[__kmp_curr_tdg_idx];
- this_tdg->rec_taskred_data =
- __kmp_allocate(sizeof(kmp_task_red_input_t) * num);
- this_tdg->rec_num_taskred = num;
- KMP_MEMCPY(this_tdg->rec_taskred_data, data,
- sizeof(kmp_task_red_input_t) * num);
+ tdg->rec_taskred_data = __kmp_allocate(sizeof(kmp_task_red_input_t) * num);
+ tdg->rec_num_taskred = num;
+ KMP_MEMCPY(tdg->rec_taskred_data, data, sizeof(kmp_task_red_input_t) * num);
}
#endif
return __kmp_task_reduction_init(gtid, num, (kmp_taskred_input_t *)data);
@@ -2661,8 +2655,7 @@ void *__kmpc_task_reduction_get_th_data(int gtid, void *tskgrp, void *data) {
#if OMPX_TASKGRAPH
if ((thread->th.th_current_task->is_taskgraph) &&
- (!__kmp_tdg_is_recording(
- __kmp_global_tdgs[__kmp_curr_tdg_idx]->tdg_status))) {
+ (!__kmp_tdg_is_recording(__kmp_curr_tdg->tdg_status))) {
tg = thread->th.th_current_task->td_taskgroup;
KMP_ASSERT(tg != NULL);
KMP_ASSERT(tg->reduce_data != NULL);
@@ -5459,6 +5452,7 @@ bool __kmpc_omp_has_task_team(kmp_int32 gtid) {
// its initial state, return the pointer to it, otherwise nullptr
static kmp_tdg_info_t *__kmp_find_tdg(kmp_int32 tdg_id) {
kmp_tdg_info_t *res = nullptr;
+ kmp_int32 i = 0;
if (__kmp_max_tdgs == 0)
return res;
@@ -5466,9 +5460,42 @@ static kmp_tdg_info_t *__kmp_find_tdg(kmp_int32 tdg_id) {
__kmp_global_tdgs = (kmp_tdg_info_t **)__kmp_allocate(
sizeof(kmp_tdg_info_t *) * __kmp_max_tdgs);
- if ((__kmp_global_tdgs[tdg_id]) &&
- (__kmp_global_tdgs[tdg_id]->tdg_status != KMP_TDG_NONE))
- res = __kmp_global_tdgs[tdg_id];
+ for (i = 0; i < __kmp_max_tdgs; i++) {
+ if (__kmp_global_tdgs[i] && __kmp_global_tdgs[i]->tdg_id == tdg_id) {
+ if (__kmp_global_tdgs[i]->tdg_status != KMP_TDG_NONE) {
+ res = __kmp_global_tdgs[i];
+ }
+ break;
+ }
+ }
+ return res;
+}
+
+// __kmp_alloc_tdg: Allocates a TDG if it doesn't already exist.
+// tdg_id: ID of the TDG.
+// returns: A pointer to the TDG if it already exists. Otherwise,
+// allocates a new TDG if the maximum limit has not been reached.
+// Returns nullptr if no TDG can be allocated.
+static kmp_tdg_info_t *__kmp_alloc_tdg(kmp_int32 tdg_id) {
+ kmp_tdg_info_t *res = nullptr;
+ kmp_int32 i = 0;
+ if ((res = __kmp_find_tdg(tdg_id))) {
+ return res;
+ }
+ if (__kmp_num_tdg > __kmp_max_tdgs) {
+ return res;
+ }
+
+ for (i = 0; i < __kmp_max_tdgs; i++) {
+ if (!__kmp_global_tdgs[i]) {
+ kmp_tdg_info_t *tdg =
+ (kmp_tdg_info_t *)__kmp_allocate(sizeof(kmp_tdg_info_t));
+ __kmp_global_tdgs[i] = tdg;
+ __kmp_curr_tdg = tdg;
+ res = __kmp_global_tdgs[i];
+ break;
+ }
+ }
return res;
}
@@ -5566,9 +5593,7 @@ void __kmp_exec_tdg(kmp_int32 gtid, kmp_tdg_info_t *tdg) {
static inline void __kmp_start_record(kmp_int32 gtid,
kmp_taskgraph_flags_t *flags,
kmp_int32 tdg_id) {
- kmp_tdg_info_t *tdg =
- (kmp_tdg_info_t *)__kmp_allocate(sizeof(kmp_tdg_info_t));
- __kmp_global_tdgs[__kmp_curr_tdg_idx] = tdg;
+ kmp_tdg_info_t *tdg = __kmp_alloc_tdg(tdg_id);
// Initializing the TDG structure
tdg->tdg_id = tdg_id;
tdg->map_size = INIT_MAPSIZE;
@@ -5593,7 +5618,7 @@ static inline void __kmp_start_record(kmp_int32 gtid,
KMP_ATOMIC_ST_RLX(&this_record_map[i].npredecessors_counter, 0);
}
- __kmp_global_tdgs[__kmp_curr_tdg_idx]->record_map = this_record_map;
+ tdg->record_map = this_record_map;
}
// __kmpc_start_record_task: Wrapper around __kmp_start_record to mark
@@ -5627,8 +5652,7 @@ kmp_int32 __kmpc_start_record_task(ident_t *loc_ref, kmp_int32 gtid,
__kmp_exec_tdg(gtid, tdg);
res = 0;
} else {
- __kmp_curr_tdg_idx = tdg_id;
- KMP_DEBUG_ASSERT(__kmp_curr_tdg_idx < __kmp_max_tdgs);
+ KMP_DEBUG_ASSERT(__kmp_num_tdg < __kmp_max_tdgs);
__kmp_start_record(gtid, flags, tdg_id);
__kmp_num_tdg++;
res = 1;
>From 99f3f8dd9fef5ce3dc6772d0e4b211bb3112f9b7 Mon Sep 17 00:00:00 2001
From: jpinot <josep.pinot at bsc.es>
Date: Tue, 11 Mar 2025 11:16:43 +0100
Subject: [PATCH 3/3] [OpenMP] Add reset parameter to __kmpc_start_record_task
This patch extends the record/replay infrastructure with the graph_reset
clause introduced in OpenMP 6.0 by adding a new reset parameter to
__kmpc_start_record_task. When reset is true, any existing task dependency
graph (TDG) for the specified ID is freed before re-recording.
---
openmp/runtime/src/kmp.h | 2 +-
openmp/runtime/src/kmp_tasking.cpp | 54 +++++++++++++++----
.../test/tasking/omp_record_replay.cpp | 5 +-
.../test/tasking/omp_record_replay_deps.cpp | 5 +-
.../tasking/omp_record_replay_multiTDGs.cpp | 8 +--
.../tasking/omp_record_replay_print_dot.cpp | 5 +-
.../tasking/omp_record_replay_taskloop.cpp | 5 +-
7 files changed, 61 insertions(+), 23 deletions(-)
diff --git a/openmp/runtime/src/kmp.h b/openmp/runtime/src/kmp.h
index 7e415a8ec9888..e76d0022fe70a 100644
--- a/openmp/runtime/src/kmp.h
+++ b/openmp/runtime/src/kmp.h
@@ -4384,7 +4384,7 @@ static inline bool __kmp_tdg_is_recording(kmp_tdg_status_t status) {
KMP_EXPORT kmp_int32 __kmpc_start_record_task(ident_t *loc, kmp_int32 gtid,
kmp_int32 input_flags,
- kmp_int32 tdg_id);
+ kmp_int32 tdg_id, bool reset);
KMP_EXPORT void __kmpc_end_record_task(ident_t *loc, kmp_int32 gtid,
kmp_int32 input_flags, kmp_int32 tdg_id);
#endif
diff --git a/openmp/runtime/src/kmp_tasking.cpp b/openmp/runtime/src/kmp_tasking.cpp
index ab82dbae7cb63..f9b8dccd41bc1 100644
--- a/openmp/runtime/src/kmp_tasking.cpp
+++ b/openmp/runtime/src/kmp_tasking.cpp
@@ -5499,6 +5499,34 @@ static kmp_tdg_info_t *__kmp_alloc_tdg(kmp_int32 tdg_id) {
return res;
}
+// __kmp_free_tdg: Frees a TDG if it exists.
+// tdg_id: ID of the TDG to be freed.
+// returns: true if a TDG with the given ID was found and successfully freed,
+// false if no such TDG exists.
+static bool __kmp_free_tdg(kmp_int32 tdg_id) {
+ kmp_tdg_info_t *tdg = nullptr;
+ kmp_int32 i = 0;
+ if (__kmp_global_tdgs == NULL)
+ return false;
+
+ for (i = 0; i < __kmp_max_tdgs; i++) {
+ if (__kmp_global_tdgs[i] && __kmp_global_tdgs[i]->tdg_id == tdg_id) {
+ tdg = __kmp_global_tdgs[i];
+ for (kmp_int i = 0; i < tdg->map_size; i++) {
+ __kmp_free(tdg->record_map[i].successors);
+ }
+ __kmp_free(tdg->record_map);
+ if (tdg->root_tasks)
+ __kmp_free(tdg->root_tasks);
+
+ __kmp_free(tdg);
+ __kmp_global_tdgs[i] = NULL;
+ return true;
+ }
+ }
+ return false;
+}
+
// __kmp_print_tdg_dot: prints the TDG to a dot file
// tdg: ID of the TDG
// gtid: Global Thread ID
@@ -5626,27 +5654,31 @@ static inline void __kmp_start_record(kmp_int32 gtid,
// loc_ref: Location of TDG, not used yet
// gtid: Global Thread ID of the encountering thread
// input_flags: Flags associated with the TDG
-// tdg_id: ID of the TDG to record, for now, incremental integer
-// returns: 1 if we record, otherwise, 0
+// tdg_id: ID of the TDG to record
+// reset: If true and a TDG with the same ID already exists, it is freed
+// before recording returns: 1 if we record, otherwise, 0
kmp_int32 __kmpc_start_record_task(ident_t *loc_ref, kmp_int32 gtid,
- kmp_int32 input_flags, kmp_int32 tdg_id) {
+ kmp_int32 input_flags, kmp_int32 tdg_id,
+ bool reset) {
kmp_int32 res;
kmp_taskgraph_flags_t *flags = (kmp_taskgraph_flags_t *)&input_flags;
- KA_TRACE(10,
- ("__kmpc_start_record_task(enter): T#%d loc=%p flags=%d tdg_id=%d\n",
- gtid, loc_ref, input_flags, tdg_id));
+ KA_TRACE(10, ("__kmpc_start_record_task(enter): T#%d loc=%p flags=%d "
+ "tdg_id=%d\n reset=%d\n",
+ gtid, loc_ref, input_flags, tdg_id, reset));
if (__kmp_max_tdgs == 0) {
- KA_TRACE(
- 10,
- ("__kmpc_start_record_task(abandon): T#%d loc=%p flags=%d tdg_id = %d, "
- "__kmp_max_tdgs = 0\n",
- gtid, loc_ref, input_flags, tdg_id));
+ KA_TRACE(10, ("__kmpc_start_record_task(abandon): T#%d loc=%p flags=%d "
+ "tdg_id = %d reset = %d, __kmp_max_tdgs = 0\n",
+ gtid, loc_ref, input_flags, tdg_id, reset));
return 1;
}
__kmpc_taskgroup(loc_ref, gtid);
+ if (reset) {
+ __kmp_free_tdg(tdg_id);
+ __kmp_num_tdg--;
+ }
if (kmp_tdg_info_t *tdg = __kmp_find_tdg(tdg_id)) {
// TODO: use re_record flag
__kmp_exec_tdg(gtid, tdg);
diff --git a/openmp/runtime/test/tasking/omp_record_replay.cpp b/openmp/runtime/test/tasking/omp_record_replay.cpp
index 69ad98003a0d6..dc753d8733c21 100644
--- a/openmp/runtime/test/tasking/omp_record_replay.cpp
+++ b/openmp/runtime/test/tasking/omp_record_replay.cpp
@@ -13,7 +13,7 @@ typedef struct ident {
#ifdef __cplusplus
extern "C" {
int __kmpc_global_thread_num(ident_t *);
- int __kmpc_start_record_task(ident_t *, int, int, int);
+ int __kmpc_start_record_task(ident_t *, int, int, int, bool);
void __kmpc_end_record_task(ident_t *, int, int , int);
}
#endif
@@ -30,7 +30,8 @@ int main() {
#pragma omp single
for (int iter = 0; iter < NT; ++iter) {
int gtid = __kmpc_global_thread_num(nullptr);
- int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0, /* tdg_id */0);
+ int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0,
+ /* tdg_id */ 0, /* reset */ false);
if (res) {
num_tasks++;
#pragma omp task
diff --git a/openmp/runtime/test/tasking/omp_record_replay_deps.cpp b/openmp/runtime/test/tasking/omp_record_replay_deps.cpp
index 9b6b370b30efc..524f9b633ffb7 100644
--- a/openmp/runtime/test/tasking/omp_record_replay_deps.cpp
+++ b/openmp/runtime/test/tasking/omp_record_replay_deps.cpp
@@ -16,7 +16,7 @@ typedef struct ident {
#ifdef __cplusplus
extern "C" {
int __kmpc_global_thread_num(ident_t *);
- int __kmpc_start_record_task(ident_t *, int, int, int);
+ int __kmpc_start_record_task(ident_t *, int, int, int, bool);
void __kmpc_end_record_task(ident_t *, int, int, int);
}
#endif
@@ -44,7 +44,8 @@ int main() {
#pragma omp single
for (int iter = 0; iter < NT; ++iter) {
int gtid = __kmpc_global_thread_num(nullptr);
- int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */0, /* tdg_id */0);
+ int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0,
+ /* tdg_id */ 0, /* reset */ false);
if (res) {
#pragma omp task depend(out:y)
add();
diff --git a/openmp/runtime/test/tasking/omp_record_replay_multiTDGs.cpp b/openmp/runtime/test/tasking/omp_record_replay_multiTDGs.cpp
index 03252843689c4..fc8763ce65fe6 100644
--- a/openmp/runtime/test/tasking/omp_record_replay_multiTDGs.cpp
+++ b/openmp/runtime/test/tasking/omp_record_replay_multiTDGs.cpp
@@ -15,7 +15,7 @@ int val;
#ifdef __cplusplus
extern "C" {
int __kmpc_global_thread_num(ident_t *);
- int __kmpc_start_record_task(ident_t *, int, int, int);
+ int __kmpc_start_record_task(ident_t *, int, int, int, bool);
void __kmpc_end_record_task(ident_t *, int, int , int);
}
#endif
@@ -43,7 +43,8 @@ int main() {
#pragma omp single
for (int iter = 0; iter < NT; ++iter) {
int gtid = __kmpc_global_thread_num(nullptr);
- int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0, /* tdg_id */0);
+ int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0,
+ /* tdg_id */ 0, /* reset */ false);
if (res) {
num_tasks++;
#pragma omp task depend(out:y)
@@ -54,7 +55,8 @@ int main() {
mult();
}
__kmpc_end_record_task(nullptr, gtid, /* kmp_tdg_flags */0, /* tdg_id */0);
- res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0, /* tdg_id */1);
+ res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0,
+ /* tdg_id */ 1, /* reset */ false);
if (res) {
num_tasks++;
#pragma omp task depend(out:y)
diff --git a/openmp/runtime/test/tasking/omp_record_replay_print_dot.cpp b/openmp/runtime/test/tasking/omp_record_replay_print_dot.cpp
index 2fe55f0815429..1dc31574a2f0f 100644
--- a/openmp/runtime/test/tasking/omp_record_replay_print_dot.cpp
+++ b/openmp/runtime/test/tasking/omp_record_replay_print_dot.cpp
@@ -13,7 +13,7 @@ typedef struct ident {
#ifdef __cplusplus
extern "C" {
int __kmpc_global_thread_num(ident_t *);
- int __kmpc_start_record_task(ident_t *, int, int, int);
+ int __kmpc_start_record_task(ident_t *, int, int, int, bool);
void __kmpc_end_record_task(ident_t *, int, int , int);
}
#endif
@@ -48,7 +48,8 @@ int main() {
#pragma omp single
{
int gtid = __kmpc_global_thread_num(nullptr);
- int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0, /* tdg_id */ 0);
+ int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0,
+ /* tdg_id */ 0, /* reset */ false);
if (res) {
#pragma omp task depend(out : x)
func(&num_exec);
diff --git a/openmp/runtime/test/tasking/omp_record_replay_taskloop.cpp b/openmp/runtime/test/tasking/omp_record_replay_taskloop.cpp
index 3d88faeeb28ee..5f61becd21330 100644
--- a/openmp/runtime/test/tasking/omp_record_replay_taskloop.cpp
+++ b/openmp/runtime/test/tasking/omp_record_replay_taskloop.cpp
@@ -14,7 +14,7 @@ typedef struct ident {
#ifdef __cplusplus
extern "C" {
int __kmpc_global_thread_num(ident_t *);
- int __kmpc_start_record_task(ident_t *, int, int, int);
+ int __kmpc_start_record_task(ident_t *, int, int, int, bool);
void __kmpc_end_record_task(ident_t *, int, int , int);
}
#endif
@@ -31,7 +31,8 @@ int main() {
#pragma omp single
for (int iter = 0; iter < NT; ++iter) {
int gtid = __kmpc_global_thread_num(nullptr);
- int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */0, /* tdg_id */0);
+ int res = __kmpc_start_record_task(nullptr, gtid, /* kmp_tdg_flags */ 0,
+ /* tdg_id */ 0, /* reset */ false);
if (res) {
num_tasks++;
#pragma omp taskloop reduction(+:sum) num_tasks(4096)
More information about the Openmp-commits
mailing list