[Openmp-commits] [openmp] [OpenMP] Mark Failing OpenMP Tests as XFAIL on Windows (PR #129040)

[Martin Storsjö via Openmp-commits]

================
@@ -21,6 +21,7 @@ config.has_libatomic = @LIBOMP_HAVE_LIBATOMIC@
 config.is_standalone_build = @OPENMP_STANDALONE_BUILD@
 config.has_omit_frame_pointer_flag = @OPENMP_TEST_COMPILER_HAS_OMIT_FRAME_POINTER_FLAGS@
 config.target_arch = "@LIBOMP_ARCH@"
+config.compiler_frontend_variant="@CMAKE_C_COMPILER_FRONTEND_VARIANT@"
----------------
mstorsjo wrote:

Nitpick: Spaces around `=`.

As for the CMake variable to inspect; there's the variable simply named `MSVC` which is set when using clang-cl too. But perhaps this one is cleaner.

There's another CMake corner case too, which we may or may not care about - one may configure CMake with the `clang` interface rather than `clang-cl`, but that being a clang that defaults to MSVC mode (but with the GNU command line interface). In that case, `CMAKE_C_COMPILER_FRONTEND_VARIANT` is `GNU`, while Clang still generates code like in msvc mode. To detect that, one can also check `CMAKE_C_SIMULATE_ID`.

In this case, I think the code generation mode aspects may be more relevant than the frontend variant, so using `CMAKE_C_SIMULATE_ID` may be slightly more correct. But I'm fine with either form.

https://github.com/llvm/llvm-project/pull/129040