[Openmp-commits] [openmp] [OpenMP][Flang]Fix omp_get_cancellation return type from integer to logical (PR #142990)
Yang Zaizhou via Openmp-commits
openmp-commits at lists.llvm.org
Mon Jun 9 05:47:25 PDT 2025
Mxfg-incense wrote:
> LGTM. Is it worth adding some sort of unit test?
I’m not sure if it’s necessary to add a test. But I found that the earliest version of `omp_get_cancellation()`, as specified in the [OpenMP 4.0 spec](https://www.openmp.org/wp-content/uploads/OpenMP4.0.0.pdf), already had its return value defined as a `logical` type, and this has not changed. It seems an error in the original implementation.
https://github.com/llvm/llvm-project/pull/142990
More information about the Openmp-commits
mailing list